Page MenuHomeFreeBSD
Differential D37332

ddb(4): misc updates
ClosedPublic
Actions

Authored by mhorne on Nov 10 2022, 5:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2024, 5:25 PM
Unknown Object (File)
Feb 16 2024, 4:52 PM
Unknown Object (File)
Feb 10 2024, 2:30 PM
Unknown Object (File)
Dec 20 2023, 4:59 AM
Unknown Object (File)
Dec 17 2023, 12:38 AM
Unknown Object (File)
Dec 12 2023, 5:34 PM
Unknown Object (File)
Nov 7 2023, 3:38 AM
Unknown Object (File)
Oct 6 2023, 2:37 AM
View All 27 Files
Subscribers
imp
pauamma_gundo.com

Details

Reviewers
jhb
markj
pauamma_gundo.com
Group Reviewers
manpages
Commits
rG4cb1a06cb68d: ddb(4): misc updates
rG94f6ee56e316: ddb(4): misc updates
Summary
  • Describe optional 'addr' argument to many show commands
  • Remove obsolete commands (show cbstat)
  • 'show jails' was renamed to 'show prison'
  • Remove superfluous commentary about sleepqueues
  • Fix an xref to gdb(4)
  • Fix issues reported by mandoc -Tlint
  • Plus a couple other inaccuracies/inconsistencies

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Nov 10 2022, 5:00 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 10 2022, 5:00 PM
mhorne requested review of this revision.Nov 10 2022, 5:00 PM
Harbormaster completed remote builds in B48258: Diff 112848.Nov 10 2022, 5:00 PM
mhorne added a child revision: D37333: ddb(4): document some missing commands.Nov 10 2022, 5:00 PM
jhb accepted this revision.Nov 10 2022, 5:20 PM
jhb added inline comments.
share/man/man4/ddb.4
1538–1539
This revision is now accepted and ready to land.Nov 10 2022, 5:20 PM
pauamma_gundo.com requested changes to this revision.Nov 10 2022, 9:28 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.
pauamma_gundo.com added inline comments.
share/man/man4/ddb.4
246–248
547–548
548–550

Should that sentence too be removed? If not, the condition "otherwise" refers to should be made explicit.

1129–1130

While here: "supposed to"? git blame says this dates back to 2008. Is it still applicable?

This revision now requires changes to proceed.Nov 10 2022, 9:28 PM
mhorne updated this revision to Diff 112942.Nov 11 2022, 3:49 PM
mhorne marked 4 inline comments as done.

Handle review comments. Rewrite descriptions for findstack and show vmopag.

Harbormaster completed remote builds in B48308: Diff 112942.Nov 11 2022, 3:50 PM
mhorne marked an inline comment as done.Nov 11 2022, 3:50 PM
markj accepted this revision.Nov 11 2022, 5:11 PM
markj added inline comments.
share/man/man4/ddb.4
865

Maybe "summarized information" or something similar instead of "short info"?

pauamma_gundo.com accepted this revision.Nov 11 2022, 5:58 PM

English LGTM now. Can't speak to correctness of descriptions.

This revision is now accepted and ready to land.Nov 11 2022, 5:58 PM
Closed by commit rG94f6ee56e316: ddb(4): misc updates (authored by mhorne). · Explain WhyNov 11 2022, 6:27 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG94f6ee56e316: ddb(4): misc updates.
mhorne added a commit: rG4cb1a06cb68d: ddb(4): misc updates.Dec 5 2022, 4:48 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
146 lines

Diff 112968

View Options

share/man/man4/ddb.4

Loading...