Page MenuHomeFreeBSD

virtio: Silence a -Wunused warning
ClosedPublic

Authored by markj on Nov 6 2022, 10:49 PM.
Tags
None
Referenced Files
F122416193: D37298.id.diff
Sat, Jul 5, 4:28 AM
Unknown Object (File)
Fri, Jul 4, 3:29 PM
Unknown Object (File)
Thu, Jul 3, 5:29 AM
Unknown Object (File)
Mon, Jun 30, 8:07 PM
Unknown Object (File)
Sun, Jun 22, 1:46 PM
Unknown Object (File)
Sat, Jun 21, 3:22 PM
Unknown Object (File)
Thu, Jun 19, 1:13 PM
Unknown Object (File)
Tue, Jun 17, 6:48 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48302
Build 45188: arc lint + arc unit

Event Timeline

markj requested review of this revision.Nov 6 2022, 10:49 PM
corvink added inline comments.
sys/dev/virtio/virtio_endian.h
44–45

This function looks like a small optimization. I don't think that this optimization makes sense because it makes the code harder to read for no value.
So IMHO, we should drop it. E.g. just use:

static inline uint16_t
virtio_htog16(bool modern, uint16_t val)
{
  if (modern)
    return (htole16(val));
  else
    return (val);
}
jhb added inline comments.
sys/dev/virtio/virtio_endian.h
44–45

I agree with Corvin's suggestion and think it is more readable.

markj marked 2 inline comments as done.

Remove virtio_swap_endian().

This revision is now accepted and ready to land.Nov 14 2022, 6:21 AM
This revision was automatically updated to reflect the committed changes.