Remove svn references from the Handbook
AcceptedPublic
Actions

Authored by carlavilla on Nov 2 2022, 6:45 PM.

Details

Reviewers

imp
bapt
bcr
emaste
lwhsu

Group Reviewers

Doc Committers
docs

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

carlavilla requested review of this revision.Nov 2 2022, 6:45 PM

carlavilla created this revision.

lwhsu added a subscriber: lwhsu.Nov 3 2022, 9:50 AM

lwhsu added inline comments.

documentation/content/en/books/handbook/security/_index.adoc
2071	This part seems an unintentional change?

carlavilla added inline comments.Nov 3 2022, 9:52 AM

documentation/content/en/books/handbook/security/_index.adoc
2071	No, I upgraded the security advisory to show a current one with the git part. I took a random security advisory

I'm on the fence of this, we haven't reached to the point to decommission svn (mirror) entirely. The point will be the EoL of stable/12. There is still requirement of using svn to get the latest code, however, I would recommend the new setup directly use git to get the latest updates. If we're not removing svn bit for now, let's add some more notes about git is the preferred way.

lwhsu added inline comments.Nov 3 2022, 10:13 AM

documentation/content/en/books/handbook/security/_index.adoc
2071	ok, I'm not sure if modifiying the EN/SA needs signing by so@, but that's a good point to update those instructions.

grahamperrin added a subscriber: grahamperrin.Nov 4 2022, 12:08 AM

grahamperrin added inline comments.

documentation/content/en/books/handbook/mirrors/_index.adoc
434	Without me seeking its point of origin: this phrase may be a source of confusion. As far as I know – correct me, please, if I'm wrong: `stable/12` is not legacy. It may help to note that `12.3-RELEASE` is production quality but not legacy in the context of recently approved https://reviews.freebsd.org/D37235. Digging deeper, via the comment above commented-out text in a September 2022 commit: … I see no legacy release. No mention of legacy in the February 2015 'Changes to the FreeBSD Support Model' https://lists.freebsd.org/pipermail/freebsd-announce/2015-February/001624.html. – https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266094#c2

emaste added a subscriber: emaste.Oct 22 2023, 7:34 PM

emaste added inline comments.

documentation/content/en/books/handbook/security/_index.adoc
2071	Updating the example SA is a good idea independent of the removal of SVN instructions. Please go ahead and commit this part.

This should have been committed long ago. Let's go ahead with it! Thanks for the work, @carlavilla !

This revision is now accepted and ready to land.Sun, May 10, 6:21 PM

ziaee added a subscriber: ziaee.Sun, May 10, 6:35 PM

ziaee added inline comments.

documentation/content/en/books/handbook/glossary.adoc
951	I would prefer if we kept just the glossary part and changed it to "historically used" because this is important context that people who grew up during the git era might not be aware of and might needs sometimes.

emaste added inline comments.Mon, May 11, 1:22 PM

documentation/content/en/books/handbook/glossary.adoc
951	If we went ahead with this review several years ago I'd agree, but FreeBSD 12 was the last version to use svn (and even then it was mirrored from git), and there's not really ongoing references to svn that might be confusing.