databases/mongodb60: update to 6.0.2

[ronald_klop.ws]

Summary

• automate mozjs configuration
  • enables powerpc64le support
  • overwrites the upstream amd64 configuration which fixes the build
  • removes almost 1 MB of patches for aarch64
• use more system libs and llvm-ar (thanks to dizzy@)
• Fix removal of (lib)zstd/zstandard directory which fixes the build on all supported platforms
• change my maintainer email to @FreeBSD.org

changes: https://www.mongodb.com/docs/manual/release-notes/6.0/#6.0.2---sep-28--2022

PR: 266587
Tested by: dizzy (libs), pkubaj (powerpc64le)
Approved by: XXX-TODO (mentor)
Co-Authored-By: dizzy, pkubaj

[ronald_klop.ws]

Clean up of the commit msg.
The commented out lines were kept in somehow.

[pkubaj]

I tested the previous version in the PR, looks good.

[rene]

databases/mongodb60/Makefile

18

Perhaps make the FreeBSD and upstream architecture names the same for consistency?

105

Minor nit, this .error is already caught by the ONLY_FOR_ARCHS above? So perhaps just

.if ${ARCH} == amd64
MOZJS_ARCH=x86_64
.elif ${ARCH} == powerpc64le
MOZJS_ARCH=ppc64le
.else
MOZJS_ARCH=${ARCH}
.endif

[ronald_klop.ws]

databases/mongodb60/Makefile

18

I used this naming on purpose to connect the architecture names used by FreeBSD to the names used by MongoDB.
https://www.mongodb.com/docs/manual/installation/#supported-platforms
I understand there are pros and cons to this. I can also just leave out the upstream architectures but choose this line a while ago. It is also used in my other mongodb ports. If you are ok with it I prefer to leave it as is.

105

I doubted quite a bit about this when I wrote it. My first version was similar to your construction. I choose the current one because I thought it might point the attention of someone doing a port to a place where some action is needed.
While developing I also don't like "secret" fall through code which might bite me later. Fail early, fail loudly. :-)
But when you would like me to change it I'm happy also.

[rene]

databases/mongodb60/Makefile

18

Ah, from an upstream point of view your naing would make more sense.

105

Fail loudly has it advantages :)

[rene]

databases/mongodb60/Makefile

105

It turns out that this fail-loud construction broke the tree, see https://cgit.FreeBSD.org/ports/commit/?id=9f13b7867d45995913dbad00c131dce4eac4bb23