Page MenuHomeFreeBSD

swap_pager: Reduce code duplication for swp_page_meta_build callers
Needs ReviewPublic

Authored by jrtc27 on Oct 13 2022, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 9:00 AM
Unknown Object (File)
Mar 12 2024, 4:43 PM
Unknown Object (File)
Mar 10 2024, 3:41 PM
Unknown Object (File)
Mar 8 2024, 3:33 PM
Unknown Object (File)
Mar 6 2024, 3:47 PM
Unknown Object (File)
Mar 6 2024, 3:22 AM
Unknown Object (File)
Dec 28 2023, 11:49 PM
Unknown Object (File)
Dec 22 2023, 11:06 PM
Subscribers

Details

Reviewers
alc
kib
markj
Summary

All callers, when swp_pager_meta_build returns a swapblk other than
SWAPBLK_NONE, either fail a KASSERT or add it to their freerange. By
passing an optional freerange to swp_pager_meta_build we can instead
deduplicate this and have swp_pager_meta_build perform the assertion or
add it to the freerange as appropriate.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47831
Build 44718: arc lint + arc unit

Event Timeline

sys/vm/swap_pager.c
2092

Not returning anything. So, do you need prev_swapblk? Just KASSERT/update here?