Page MenuHomeFreeBSD

vm_page: Fix a logic error in the handling of PQ_ACTIVE operations

Authored by markj on Sep 30 2022, 3:36 PM.
Referenced Files
F62508592: D36839.diff
Thu, Jun 8, 11:56 AM
Unknown Object (File)
May 3 2023, 9:39 PM
Unknown Object (File)
May 3 2023, 1:42 PM
Unknown Object (File)
May 3 2023, 1:07 PM
Unknown Object (File)
Apr 7 2023, 11:18 AM
Unknown Object (File)
Jan 9 2023, 4:35 AM
Unknown Object (File)
Jan 9 2023, 3:51 AM
Unknown Object (File)
Dec 15 2022, 8:03 PM



As an optimization, vm_page_activate() avoids requeuing a page that's
already in the active queue. A page's location in the active queue is
mostly unimportant.

When a page is unwired and placed back in the page queues,
vm_page_unwire() avoids moving pages out of PQ_ACTIVE to honour the
request, the idea being that they're likely mapped and so will simply
get bounced back in to PQ_ACTIVE during a queue scan.

In both cases, if the page was logically in PQ_ACTIVE but had not yet
been physically enqueued (i.e., the page is in a per-CPU batch), we
would end up clearing PGA_REQUEUE from the page. Then, batch processing
would ignore the page, so it would end up unwired and not in any queues.
This can arise, for example, when a page is allocated and then
vm_page_activate() is called multiple times in quick succession. The
result is that the page is hidden from the page daemon, so while it will
be freed when its VM object is destroyed, it cannot be reclaimed under
memory pressure.

Fix the bug: when checking if a page is in PQ_ACTIVE, only perform the
optimization if the page is physically enqueued.

Fixes: f3f38e2580f1 ("Start implementing queue state updates using fcmpset loops.")
PR: 256507

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable