Page MenuHomeFreeBSD

systat: Fix a bunch of use after frees in fetch_ifstat().
ClosedPublic

Authored by jhb on Sep 29 2022, 10:34 PM.
Tags
None
Referenced Files
F110438991: D36823.diff
Tue, Feb 18, 11:57 AM
Unknown Object (File)
Thu, Jan 30, 6:49 PM
Unknown Object (File)
Sun, Jan 26, 12:40 PM
Unknown Object (File)
Jan 12 2025, 12:35 PM
Unknown Object (File)
Jan 11 2025, 8:11 AM
Unknown Object (File)
Jan 11 2025, 4:07 AM
Unknown Object (File)
Jan 9 2025, 6:00 AM
Unknown Object (File)
Jan 9 2025, 5:14 AM
Subscribers

Details

Summary

I think this was probably just a typo. initifstat() continues around
a similar loop if the mib data fails to fetch, and fetch_ifstat() was
already using a FOREACH_SAFE loop here so expected to keep going.
Calling clearifstat() from the fetch routine also seems wrong, and the
sort_interface_list() call triggered by the existing needsort = 1 will
itself set needclear to trigger a future clearifstat().

Reported by: GCC 12 -Wuse-after-free

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable