Page MenuHomeFreeBSD

extres: syscon: pull in sys/malloc.h (fix !FDT)
ClosedPublic

Authored by kevans on Sep 29 2022, 6:12 AM.
Tags
None
Referenced Files
F133527063: D36787.diff
Sun, Oct 26, 10:31 AM
F133428367: D36787.id111169.diff
Sat, Oct 25, 5:43 PM
Unknown Object (File)
Sat, Oct 25, 1:14 PM
Unknown Object (File)
Thu, Oct 23, 9:08 PM
Unknown Object (File)
Mon, Oct 20, 2:15 AM
Unknown Object (File)
Sat, Oct 18, 2:20 PM
Unknown Object (File)
Fri, Oct 17, 10:27 AM
Unknown Object (File)
Mon, Oct 13, 5:09 PM
Subscribers

Details

Summary

syscon currently includes sys/malloc.h via header pollution from
dev/ofw/ofw_bus.h -> dev/ofw/openfirm.h. Fix the build without FDT
defined by including sys/malloc.h directly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 29 2022, 6:33 AM

I like this. For more obscure .h files an ifdef might make sense, but for sys/malloc.h, I think unconditional is fine.