extres: syscon: pull in sys/malloc.h (fix !FDT)
ClosedPublic
Actions

Authored by kevans on Sep 29 2022, 6:12 AM.

Details

Reviewers

manu
andrew
imp

Group Reviewers

arm64

Commits

rG79794d5c18b7: extres: syscon: pull in sys/malloc.h (fix !FDT)

Summary

syscon currently includes sys/malloc.h via header pollution from
dev/ofw/ofw_bus.h -> dev/ofw/openfirm.h. Fix the build without FDT
defined by including sys/malloc.h directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 29 2022, 6:12 AM

Herald added a reviewer: manu. · View Herald TranscriptSep 29 2022, 6:12 AM

Herald added a subscriber: imp. · View Herald Transcript

kevans requested review of this revision.Sep 29 2022, 6:12 AM

Harbormaster completed remote builds in B47599: Diff 111169.Sep 29 2022, 6:12 AM

kevans added a child revision: D36788: uart: uart_cpu_arm64: fix the build without FDT.Sep 29 2022, 6:12 AM

manu accepted this revision.Sep 29 2022, 6:33 AM

This revision is now accepted and ready to land.Sep 29 2022, 6:33 AM

andrew accepted this revision.Sep 29 2022, 2:31 PM

I like this. For more obscure .h files an ifdef might make sense, but for sys/malloc.h, I think unconditional is fine.

Closed by commit rG79794d5c18b7: extres: syscon: pull in sys/malloc.h (fix !FDT) (authored by kevans). · Explain WhySep 29 2022, 7:34 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG79794d5c18b7: extres: syscon: pull in sys/malloc.h (fix !FDT).

Revision Contents
Changeset List

Path

Size

sys/

dev/

extres/

syscon/

syscon.c

1 line

Diff 111206

View Options

sys/dev/extres/syscon/syscon.c

extres: syscon: pull in sys/malloc.h (fix !FDT)ClosedPublicActions