Page MenuHomeFreeBSD

extres: syscon: pull in sys/malloc.h (fix !FDT)
ClosedPublic

Authored by kevans on Sep 29 2022, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:09 PM
Unknown Object (File)
Thu, Oct 9, 11:07 PM
Unknown Object (File)
Thu, Oct 9, 11:07 PM
Unknown Object (File)
Thu, Oct 9, 11:07 PM
Unknown Object (File)
Thu, Oct 9, 7:30 PM
Unknown Object (File)
Sun, Sep 21, 2:41 AM
Unknown Object (File)
Wed, Sep 17, 7:17 PM
Unknown Object (File)
Sep 16 2025, 10:56 AM
Subscribers

Details

Summary

syscon currently includes sys/malloc.h via header pollution from
dev/ofw/ofw_bus.h -> dev/ofw/openfirm.h. Fix the build without FDT
defined by including sys/malloc.h directly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 29 2022, 6:33 AM

I like this. For more obscure .h files an ifdef might make sense, but for sys/malloc.h, I think unconditional is fine.