freebsd-update.sh: EDITOR: if not set, prefer ee
Needs ReviewPublic
Actions

Authored by grahamperrin on Sep 29 2022, 2:33 AM.

Details

Reviewers

emaste
cperciva
delphij

Summary

Reduce the risk of end users stumbling whilst attempting to upgrade the operating system.

Test Plan

https://www.freebsd.org/where/#past
download and install an end-of-life FreeBSD 13.0-RELEASE that supports binary updates
use freebsd-update(8) to update, but not upgrade
boot 13.0-RELEASE-p13
add a user to the video group
https://www.freebsd.org/releases/13.1R/installation/#upgrade-binary use freebsd-update(8) to begin an upgrade to 13.1-RELEASE
when prompted, edit files
check the end result.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

grahamperrin created this revision.Sep 29 2022, 2:33 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 2:33 AM

grahamperrin requested review of this revision.Sep 29 2022, 2:33 AM

Alexander88207_protonmail.com added a subscriber: Alexander88207_protonmail.com.Sep 30 2022, 5:50 PM

emaste edited reviewers, added: emaste, cperciva, delphij; removed: Src Committers.Mar 6 2023, 5:11 PM

For those of you who have not already seen the related pull request:

please ignore the series of grahamperrin pushed messages at and under https://github.com/grahamperrin/freebsd-src/pull/1#ref-commit-4d5aef3.

As far as I can tell, the misrepresentations are a somewhat avoidable side-effect of using forks for pull requests. Postscript:

#42 - Committer's guide: discourage use of the # number sign before a number in commit log messages - freebsd-doc - Codeberg.org

The tail of today's https://old.reddit.com/r/freebsd/comments/18gtb5r/-/:

Is there any reason why I'm forced to use vi? Talk about a ginormous headache. It isn't something that I want to learn or even know exists. This is super frustrating.

Maybe the people that did the installer/upgrade utility should ask which is the preferred editor prior to bringing up the merge conflict prompt.

I have no objection (ee would at least give user some hint about how to use it, e.g. use Esc to get a menu, etc.), but I doubt if this change would have any actual effect, because EDITOR is set to vi in .profile as well as .cshrc so the user gets vi anyway...

@delphij thanks for the context.

I probably opened this at a time when I was struggling to understand which multiple files combine to reliably avoid unwanted appearance of vi.

I forgot:

https://github.com/freebsd/freebsd-src/blob/main/bin/sh/profile

# System-wide .profile file for sh(1).

If I'm not mistaken:

/etc/profile does not set EDITOR …

grahamperrin reclaimed this revision.Dec 15 2023, 8:04 AM

In D36786#981862, @grahamperrin wrote:

I forgot:

https://github.com/freebsd/freebsd-src/blob/main/bin/sh/profile

# System-wide .profile file for sh(1).

If I'm not mistaken:

/etc/profile does not set EDITOR …

/etc/profile is not .profile.

On a fresh FreeBSD 14.0 test install no EDITOR is set for root. I see setenv EDITOR vi in /root/.cshrc. New user accounts will inherit EDITOR=vi via .profile from /usr/share/skel/dot.profile.