Page MenuHomeFreeBSD
Differential D36542

vfs: always retain path buffer after lookup
ClosedPublic
Actions

Authored by mjg on Sep 12 2022, 11:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 9:22 PM
Unknown Object (File)
Mon, Nov 3, 1:35 PM
Unknown Object (File)
Thu, Oct 30, 1:12 PM
Unknown Object (File)
Mon, Oct 27, 8:27 PM
Unknown Object (File)
Mon, Oct 27, 8:25 PM
Unknown Object (File)
Sun, Oct 26, 12:09 AM
Unknown Object (File)
Wed, Oct 22, 1:40 PM
Unknown Object (File)
Wed, Oct 22, 1:40 PM
View All Files
Subscribers
asomers
delphij
rmacklem

Details

Reviewers
kib
Commits
rG5b5b7e2ca2fa: vfs: always retain path buffer after lookup
Summary

This removes some of the complexity needed to maintain HASBUF and allows for removal of SAVENAME injections by filesystems.

Ultimately both flags get retired.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Sep 12 2022, 11:10 PM
Herald added subscribers: asomers, delphij. · View Herald TranscriptSep 12 2022, 11:10 PM
mjg requested review of this revision.Sep 12 2022, 11:10 PM
kib accepted this revision.Sep 13 2022, 7:38 PM
kib added inline comments.
sys/sys/namei.h
163

I believe it is useful to assert that removed flags are not passed to NDINIT() or namei()

This revision is now accepted and ready to land.Sep 13 2022, 7:38 PM
mjg added a subscriber: rmacklem.Sep 14 2022, 6:28 PM

@rmacklem can you give this patch a spin please concerning nfs parts? works for me(tm)

mjg closed this revision.Sep 17 2022, 12:19 PM

5b5b7e2ca2fa9a2418dd51749f4ef6f881ae7179

rmacklem added a comment.Sep 19 2022, 11:06 PM

I ran a test cycle for NFS using a main kernel
with this patch committed in it and did not see
any problems.

mjg added a commit: rG5b5b7e2ca2fa: vfs: always retain path buffer after lookup.Oct 19 2022, 1:09 PM
grahamperrin mentioned this in D37074: emulators/virtualbox-ose: fix builds on CURRENT.Oct 20 2022, 6:57 PM
grahamperrin mentioned this in R11:c35a71080172: emulators/virtualbox-ose: fix builds on CURRENT.Dec 19 2022, 9:34 PM

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
os/
freebsd/
zfs/
23 lines
fs/
devfs/
1 line
ext2fs/
8 lines
17 lines
fuse/
14 lines
msdosfs/
4 lines
13 lines
nfsclient/
14 lines
nfsserver/
21 lines
8 lines
smbfs/
5 lines
tmpfs/
1 line
10 lines
unionfs/
25 lines
9 lines
kern/
2 lines
5 lines
4 lines
32 lines
116 lines
2 lines
52 lines
sys/
30 lines
2 lines
ufs/
ufs/
6 lines
20 lines

Diff 110484

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Loading...
View Options

sys/fs/devfs/devfs_vnops.c

Loading...
View Options

sys/fs/ext2fs/ext2_lookup.c

Loading...
View Options

sys/fs/ext2fs/ext2_vnops.c

Loading...
View Options

sys/fs/fuse/fuse_vnops.c

Loading...
View Options

sys/fs/msdosfs/msdosfs_lookup.c

Loading...
View Options

sys/fs/msdosfs/msdosfs_vnops.c

Loading...
View Options

sys/fs/nfsclient/nfs_clvnops.c

Loading...
View Options

sys/fs/nfsserver/nfs_nfsdport.c

Loading...
View Options

sys/fs/nfsserver/nfs_nfsdserv.c

Loading...
View Options

sys/fs/smbfs/smbfs_vnops.c

Loading...
View Options

sys/fs/tmpfs/tmpfs_subr.c

Loading...
View Options

sys/fs/tmpfs/tmpfs_vnops.c

Loading...
View Options

sys/fs/unionfs/union_subr.c

Loading...
View Options

sys/fs/unionfs/union_vnops.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...
View Options

sys/kern/uipc_mqueue.c

Loading...
View Options

sys/kern/uipc_usrreq.c

Loading...
View Options

sys/kern/vfs_cache.c

Loading...
View Options

sys/kern/vfs_lookup.c

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/sys/namei.h

Loading...
View Options

sys/sys/param.h

Loading...
View Options

sys/ufs/ufs/ufs_lookup.c

Loading...
View Options

sys/ufs/ufs/ufs_vnops.c

Loading...