Page MenuHomeFreeBSD
Differential D36462

update the man page for having nolockd enabled for NFSv4
ClosedPublic
Actions

Authored by rmacklem on Sep 5 2022, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 9:46 PM
Unknown Object (File)
Tue, Apr 16, 6:50 PM
Unknown Object (File)
Tue, Apr 16, 3:23 AM
Unknown Object (File)
Thu, Apr 11, 7:57 AM
Unknown Object (File)
Thu, Apr 11, 6:52 AM
Unknown Object (File)
Feb 22 2024, 6:05 AM
Unknown Object (File)
Dec 23 2023, 1:40 AM
Unknown Object (File)
Dec 10 2023, 10:31 PM
View All 40 Files
Subscribers
gbe
imp

Details

Reviewers
karels
gbe
Group Reviewers
manpages
Commits
rG9b436906fa10: mount_nfs.8: Update for NFSv4 use of "nolockd"
Summary

Commit 33721eb991d8 enabled the use of the "nolockd"
option for NFSv4 mounts. The main reason for doing this
is to allow it to be used along with the "intr" mount option,
so that file locks are not left in a indeterminate state on the
NFS server when an RPC is interrupted by a signal.

This patch updates the man page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rmacklem created this revision.Sep 5 2022, 9:01 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 5 2022, 9:01 PM
rmacklem requested review of this revision.Sep 5 2022, 9:01 PM
karels added inline comments.Sep 5 2022, 9:25 PM
sbin/mount_nfs/mount_nfs.8
338–340

This sentence was ambiguous before (does "not" apply to "handle locks"?), and this makes it more convoluted. I'd suggest breaking it up, e.g. "do not use these daemons. They handle locks ... unless this option is specified.

rmacklem updated this revision to Diff 110240.Sep 7 2022, 1:26 AM

Split sentence into two sentences, as suggested by karels@.

rmacklem marked an inline comment as done.Sep 7 2022, 1:27 AM
karels accepted this revision.Sep 7 2022, 3:15 AM

I don't know if manpages have any comments, but this looks good to me.

This revision is now accepted and ready to land.Sep 7 2022, 3:15 AM
gbe accepted this revision.Sep 7 2022, 4:49 AM
gbe added a subscriber: gbe.

LGTM.

Closed by commit rG9b436906fa10: mount_nfs.8: Update for NFSv4 use of "nolockd" (authored by rmacklem). · Explain WhySep 7 2022, 9:09 PM
This revision was automatically updated to reflect the committed changes.
rmacklem added a commit: rG9b436906fa10: mount_nfs.8: Update for NFSv4 use of "nolockd".

Revision Contents
Changeset List

PathSize
sbin/
mount_nfs/
40 lines

Diff 110329

View Options

sbin/mount_nfs/mount_nfs.8

Loading...