Page MenuHomeFreeBSD
Differential D36429

raw ip: fix regression with multicast and RSVP
ClosedPublic
Actions

Authored by glebius on Sep 2 2022, 5:33 PM.
Tags
None
Referenced Files
F86870809: D36429.id.diff
Wed, Jun 26, 7:46 PM
Unknown Object (File)
Tue, Jun 25, 8:22 AM
Unknown Object (File)
Sun, Jun 16, 1:58 AM
Unknown Object (File)
Sat, Jun 15, 4:53 AM
Unknown Object (File)
Sat, Jun 15, 4:45 AM
Unknown Object (File)
May 25 2024, 10:40 AM
Unknown Object (File)
May 24 2024, 10:09 AM
Unknown Object (File)
May 5 2024, 2:01 AM
View All 44 Files
Subscribers
ae
imp
melifaro

Details

Reviewers
• karels
Group Reviewers
network
Commits
rG74ed2e8ab202: raw ip: fix regression with multicast and RSVP
Summary

With 61f7427f02a raw sockets protosw has wildcard pr_protocol. Protocol
of a specific pcb is stored in inp_ip_p.

Reported by: karels
Fixes: 61f7427f02a307d28af674a12c45dd546e3898e4

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Sep 2 2022, 5:33 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 2 2022, 5:33 PM
glebius requested review of this revision.Sep 2 2022, 5:33 PM
Harbormaster completed remote builds in B47235: Diff 110083.Sep 2 2022, 5:34 PM
• karels added a comment.Sep 2 2022, 6:07 PM

Looks good as far as it goes. I think ip6_mroute and probably others have similar problems. rsvp does.

glebius retitled this revision from mroute: fix regression with MRT_INIT to raw ip: fix regression with multicast and RSVP.Sep 2 2022, 6:23 PM
• karels added a comment.Sep 2 2022, 6:27 PM

See also a couple of uses of pr_protocol in ip6_output.c (ICMPv6).

glebius updated this revision to Diff 110084.Sep 2 2022, 6:30 PM

Ok, I think I found them all. Sorry for breakage :(

Everything that the regression test suite catches was included
in the 61f7427f02a307d28af674a12c45dd546e3898e4.

Herald added a subscriber: ae. · View Herald TranscriptSep 2 2022, 6:30 PM
Harbormaster completed remote builds in B47236: Diff 110084.Sep 2 2022, 6:30 PM
• karels accepted this revision.Sep 2 2022, 7:09 PM

LGTM; I think this covers everything that my survey of pr_protocol use found.

This revision is now accepted and ready to land.Sep 2 2022, 7:09 PM
Closed by commit rG74ed2e8ab202: raw ip: fix regression with multicast and RSVP (authored by glebius). · Explain WhySep 2 2022, 7:17 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG74ed2e8ab202: raw ip: fix regression with multicast and RSVP.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines
6 lines
8 lines
netinet6/
7 lines
5 lines
7 lines

Diff 110085

View Options

sys/netinet/ip_input.c

Loading...
View Options

sys/netinet/ip_mroute.c

Loading...
View Options

sys/netinet/raw_ip.c

Loading...
View Options

sys/netinet6/ip6_mroute.c

Loading...
View Options

sys/netinet6/ip6_output.c

Loading...
View Options

sys/netinet6/raw_ip6.c

Loading...