The simplest OSS MIDI example

[• hselasky]

share/examples/sound/midi.c

47

Make sure you wait for 0x80 MSB set.

if (!(raw & 0x80))
continue;

[• hselasky]

Remove double line breaks?

[• hselasky]

share/examples/sound/midi.c

72

All switch cases should have a "default:"

share/examples/sound/ossmidi.h

33

Use #define or enum here.

[• hselasky]

share/examples/sound/ossmidi.h

32

NOTE_MASK -> CMD_MASK

[• hselasky]

Looks good, though I might want to format the code w.r.t. style a bit more before commit? Who will submit this?

[meka_tilda.center]

To be honest I don't know how the process works. Can you advise, please?

[meka_tilda.center]

As for formatting, this is the output that indent(1) produced. Can you tell me what would make it better?

[pstef]

In D36195#822210, @meka_tilda.center wrote:

To be honest I don't know how the process works. Can you advise, please?

I think it's just a matter of you saying how you want to be referred to in the author field of the git commit :) But I think it requires a "name <email>" format.

In D36195#822212, @meka_tilda.center wrote:

As for formatting, this is the output that indent(1) produced. Can you tell me what would make it better?

indent is a hack from the 70s, but it can be made to produce fairly style-complaint formatting if you use it with the profile that you can find under share/examples/indent/indent.pro.
Generally we apply rules from style(9) but we also apply the existing style from a file to new code in that file. Since the two don't always agree, we sometimes reformat existing code to be style(9)-compliant and then add the new code.

[meka_tilda.center]

In D36195#822271, @pstef wrote:

I think it's just a matter of you saying how you want to be referred to in the author field of the git commit :) But I think it requires a "name <email>" format.

I though "git format-patch" will do the right thing here. But anway "Goran Mekić <[e-mail]>" is prefered.

In D36195#822271, @pstef wrote:

indent is a hack from the 70s, but it can be made to produce fairly style-complaint formatting if you use it with the profile that you can find under share/examples/indent/indent.pro.
Generally we apply rules from style(9) but we also apply the existing style from a file to new code in that file. Since the two don't always agree, we sometimes reformat existing code to be style(9)-compliant and then add the new code.

I didn't know there are differences between indent(1) and style(9). I am now using profile from examples and the following is the product of it. I see there's vim integration with style(9) so I'll try to incorporate it into my own config.