Page MenuHomeFreeBSD
Differential D36021

linuxkpi: Add dev_info_once
ClosedPublic
Actions

Authored by manu on Aug 2 2022, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 9:06 PM
Unknown Object (File)
Fri, Apr 26, 12:40 AM
Unknown Object (File)
Thu, Apr 25, 2:43 PM
Unknown Object (File)
Thu, Apr 25, 2:43 PM
Unknown Object (File)
Thu, Apr 25, 2:42 PM
Unknown Object (File)
Thu, Apr 25, 10:26 AM
Unknown Object (File)
Thu, Apr 18, 1:34 PM
Unknown Object (File)
Tue, Apr 16, 9:35 AM
View All 19 Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
None
Commits
rG8d5dbbc94208: linuxkpi: Add dev_info_once
rGa7727e1a6d5d: linuxkpi: Add dev_info_once
Summary

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46723
Build 43612: arc lint + arc unit

Event Timeline

manu created this revision.Aug 2 2022, 3:32 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 2 2022, 3:32 PM
manu requested review of this revision.Aug 2 2022, 3:32 PM
Harbormaster completed remote builds in B46723: Diff 108818.Aug 2 2022, 3:32 PM
manu added a parent revision: D36020: linuxkpi: Add smp_mb__before/after_atomic.Aug 2 2022, 3:32 PM
manu added a child revision: D36022: linuxkpi: Add arch_io_{reserve,free}_memtype_wc.
emaste added inline comments.Aug 2 2022, 4:10 PM
sys/compat/linuxkpi/common/include/linux/device.h
199

odd whitespace here
also I'd say = true is canonical

manu updated this revision to Diff 108902.Aug 5 2022, 7:47 AM

Address comments from @emaste

Harbormaster completed remote builds in B46754: Diff 108902.Aug 5 2022, 7:47 AM
bz added a subscriber: bz.Aug 5 2022, 10:26 AM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/device.h
199

Indentation still looks odd; is this just in Phabricator?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2022, 2:07 PM
Closed by commit rGa7727e1a6d5d: linuxkpi: Add dev_info_once (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGa7727e1a6d5d: linuxkpi: Add dev_info_once.
manu added a commit: rG8d5dbbc94208: linuxkpi: Add dev_info_once.Sep 7 2022, 3:17 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
8 lines

Diff 108818

View Options

sys/compat/linuxkpi/common/include/linux/device.h

Loading...