tcp.4: Add missing sysctls, other fixes
ClosedPublic
Actions

Authored by karels on Jul 31 2022, 8:15 PM.

Details

Reviewers

tuexen
pauamma_gundo.com

Group Reviewers

manpages
transport

Commits

rG3dce6f96e515: tcp.4: Add missing sysctls, other fixes

Summary

Add some of the missing sysctls to tcp.4, using references to other
man pages where they exist. Added sysctls include recvbuf and sendbuf
controls for automatic buffer sizing. Updated recvspace and sendspace.

Add sysctl.8 to "see also" and intro to variable section. Rename
"MIB Variables" section to "MIB (sysctl) Variables", as most people
will associate with sysctl.

Test Plan

tested with mandoc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels created this revision.Jul 31 2022, 8:15 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2022, 8:15 PM

karels requested review of this revision.Jul 31 2022, 8:15 PM

Harbormaster completed remote builds in B46694: Diff 108757.Jul 31 2022, 8:15 PM

tuexen accepted this revision.Jul 31 2022, 8:41 PM

This revision is now accepted and ready to land.Jul 31 2022, 8:41 PM

pauamma_gundo.com requested changes to this revision.Aug 1 2022, 1:23 AM

pauamma_gundo.com added a subscriber: pauamma_gundo.com.

pauamma_gundo.com added inline comments.

share/man/man4/tcp.4
423–424
436	While here.
755
765	Tangent question; what does "gently" mean here? Slightly, ie by a small amount overall? Slowly, ie at a low pace overall change regardless, or not abruptly? Or is it a typo for "greatly"?

This revision now requires changes to proceed.Aug 1 2022, 1:23 AM

Address review comments so far.

Harbormaster completed remote builds in B46702: Diff 108779.Aug 1 2022, 12:50 PM

karels added inline comments.Aug 1 2022, 12:50 PM

share/man/man4/tcp.4
436	Done in two places.
765	I think it means gradually, and probably by a small amount, but I don't know this algorithm.

pauamma_gundo.com accepted this revision.Aug 1 2022, 2:23 PM

pauamma_gundo.com added inline comments.

share/man/man4/tcp.4
765	I think it means gradually, and probably by a small amount, but I don't know this algorithm. Then I suggest changing it to "gradually" pending review by someone who does. Here or in another Phab review is up to you.