Page MenuHomeFreeBSD

inet.4 icmp.4 udp.4: Add missing sysctls, other fixes
ClosedPublic

Authored by karels on Sun, Jul 31, 5:43 PM.

Details

Summary

Add missing sysctls to inet.4 and icmp.4, using references to ip.4
for variables and groups documented there. Add sysctl.8 to "see also"
and intro to variable section. Rename "MIB Variables" section to
"MIB (sysctl) Variables", as most people will associate with sysctl.
Revise history: the ICMP implementation was in 4.2BSD.

Test Plan

tested with mandoc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pauamma added a subscriber: pauamma.
pauamma added inline comments.
share/man/man4/icmp.4
163–164
209

While here

share/man/man4/inet.4
168–169
181
187
226
234
272
279
share/man/man4/udp.4
120–121
This revision now requires changes to proceed.Sun, Jul 31, 11:08 PM
share/man/man4/icmp.4
163–164

The reason I used "and" is that the variables can be read or modified with sysctl(3) as well. Is there a better way to reflect that? sysctl(8) is far more common, so I wanted to mention it.

share/man/man4/inet.4
226

"Node" is intentional; it is a node in the tree of variables, with other variables below it.

234

As above

share/man/man4/icmp.4
163–164

Maybe "which can also be read or modified with sysctl(8)"?

share/man/man4/icmp.4
163–164

Maybe "which can also be read or modified with sysctl(8)"?

That works.

share/man/man4/inet.4
226

"Node" is intentional; it is a node in the tree of variables, with other variables below it.

Maybe "This is a node" then? Or use "net.inet.ip.mcast.*"?

karels marked 9 inline comments as done.

Address review comments

I believe all comments should be resolved now. About node: I used "the x.y.z node".

This revision is now accepted and ready to land.Mon, Aug 1, 2:17 PM