inet.4 icmp.4 udp.4: Add missing sysctls, other fixes
ClosedPublic
Actions

Authored by karels on Jul 31 2022, 5:43 PM.

Details

Reviewers

Group Reviewers

manpages
network

Commits

rGcf2ca148d9d6: inet.4 icmp.4 udp.4: Add missing sysctls, other fixes

Summary

Add missing sysctls to inet.4 and icmp.4, using references to ip.4
for variables and groups documented there. Add sysctl.8 to "see also"
and intro to variable section. Rename "MIB Variables" section to
"MIB (sysctl) Variables", as most people will associate with sysctl.
Revise history: the ICMP implementation was in 4.2BSD.

Test Plan

tested with mandoc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels created this revision.Jul 31 2022, 5:43 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2022, 5:43 PM

karels requested review of this revision.Jul 31 2022, 5:43 PM

Harbormaster completed remote builds in B46693: Diff 108754.Jul 31 2022, 5:44 PM

pauamma_gundo.com requested changes to this revision.Jul 31 2022, 11:08 PM

pauamma_gundo.com added a subscriber: pauamma_gundo.com.

pauamma_gundo.com added inline comments.

share/man/man4/icmp.4
163–164
209	While here
share/man/man4/inet.4
168–169
182
188
227
235
273
280
share/man/man4/udp.4
120–121

This revision now requires changes to proceed.Jul 31 2022, 11:08 PM

karels added inline comments.Aug 1 2022, 1:33 AM

share/man/man4/icmp.4
163–164	The reason I used "and" is that the variables can be read or modified with sysctl(3) as well. Is there a better way to reflect that? sysctl(8) is far more common, so I wanted to mention it.
share/man/man4/inet.4
227	"Node" is intentional; it is a node in the tree of variables, with other variables below it.
235	As above

karels added inline comments.Aug 1 2022, 1:55 AM

share/man/man4/icmp.4
163–164	Maybe "which can also be read or modified with sysctl(8)"?

pauamma_gundo.com added inline comments.Aug 1 2022, 2:55 AM

share/man/man4/icmp.4
163–164	Maybe "which can also be read or modified with sysctl(8)"? That works.
share/man/man4/inet.4
227	"Node" is intentional; it is a node in the tree of variables, with other variables below it. Maybe "This is a node" then? Or use "net.inet.ip.mcast.*"?