Details

Reviewers

tsoome
kevans
manu

Commits

rGcffdb3f5e2da: stand: Move i386_devdesc to a union
rGf197c0bf3e07: stand: Move i386_devdesc to a union

Summary

Rather than have the magic, hand-crafted fields that have to align with
fields in other structures at the end of i386_devdesc, make it into
anonymous union and adjust the code accordingly. This is safer and
similar to what CAM does.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46640
Build 43529: arc lint + arc unit

Event Timeline

imp created this revision.Jul 27 2022, 3:39 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 27 2022, 3:39 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jul 27 2022, 3:39 PM

Harbormaster completed remote builds in B46622: Diff 108606.Jul 27 2022, 3:40 PM

I like it... I'm not really a fan of the naming, but I can't exactly come up with a better suggestion so take that for the very little that it's worth.

I like it too.

This revision is now accepted and ready to land.Jul 27 2022, 5:50 PM

Let's try 'disk' instead of ddd and 'zfs' instad of zdd.

This revision now requires review to proceed.Jul 28 2022, 2:38 PM

Harbormaster completed remote builds in B46635: Diff 108640.Jul 28 2022, 2:38 PM

That seems intuitive enough, thanks! :-)

This revision is now accepted and ready to land.Jul 28 2022, 3:18 PM

tsoome accepted this revision.Jul 28 2022, 4:49 PM

Minor rebase

This revision now requires review to proceed.Jul 28 2022, 4:52 PM

Harbormaster completed remote builds in B46640: Diff 108647.Jul 28 2022, 4:52 PM

ddd