Page MenuHomeFreeBSD

stand: Move i386_devdesc to a union
ClosedPublic

Authored by imp on Wed, Jul 27, 3:39 PM.

Details

Summary

Rather than have the magic, hand-crafted fields that have to align with
fields in other structures at the end of i386_devdesc, make it into
anonymous union and adjust the code accordingly. This is safer and
similar to what CAM does.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Wed, Jul 27, 3:39 PM

I like it... I'm not really a fan of the naming, but I can't exactly come up with a better suggestion so take that for the very little that it's worth.

This revision is now accepted and ready to land.Wed, Jul 27, 5:50 PM

Let's try 'disk' instead of ddd and 'zfs' instad of zdd.

This revision now requires review to proceed.Thu, Jul 28, 2:38 PM

That seems intuitive enough, thanks! :-)

This revision is now accepted and ready to land.Thu, Jul 28, 3:18 PM
This revision now requires review to proceed.Thu, Jul 28, 4:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 11, 4:27 PM
This revision was automatically updated to reflect the committed changes.