Page MenuHomeFreeBSD
Differential D35943

linuxkpi: Add some memset functions
ClosedPublic
Actions

Authored by manu on Jul 26 2022, 9:32 AM.
Tags
None
Referenced Files
F139436834: D35943.id108796.diff
Fri, Dec 12, 2:00 AM
F139413383: D35943.id108546.diff
Thu, Dec 11, 7:33 PM
F139394614: D35943.diff
Thu, Dec 11, 3:41 PM
Unknown Object (File)
Thu, Dec 11, 7:20 AM
Unknown Object (File)
Tue, Dec 9, 12:53 PM
Unknown Object (File)
Sat, Dec 6, 10:56 PM
Unknown Object (File)
Sat, Dec 6, 12:52 AM
Unknown Object (File)
Sun, Nov 30, 11:49 AM
View All Files
Subscribers
bz
emaste
• hselasky
imp
linuxkpi

Details

Reviewers
None
Group Reviewers
linuxkpi
Commits
rGaf4fb0c0fe1c: linuxkpi: Add some memset functions
rGfa1f02baafd3: linuxkpi: Add some memset functions
Summary

Needed by drm-kmod
Obtained from: OpenBSD
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46590
Build 43479: arc lint + arc unit

Event Timeline

manu created this revision.Jul 26 2022, 9:32 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJul 26 2022, 9:32 AM
manu requested review of this revision.Jul 26 2022, 9:32 AM
Harbormaster completed remote builds in B46590: Diff 108544.Jul 26 2022, 9:32 AM
manu added a reviewer: linuxkpi.Jul 26 2022, 9:34 AM
• hselasky added a subscriber: • hselasky.Jul 26 2022, 9:53 AM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/string.h
223

Please make a new loop here:

void **dst = p;

while (n--)
*dst++ = v;

return (p);

manu updated this revision to Diff 108546.Jul 26 2022, 3:15 PM

Switch memset32/memset64 (badly copy/pasted)

sys/compat/linuxkpi/common/include/linux/string.h
223

Why ?

Harbormaster completed remote builds in B46591: Diff 108546.Jul 26 2022, 3:15 PM
• hselasky added inline comments.Jul 26 2022, 3:57 PM
sys/compat/linuxkpi/common/include/linux/string.h
223

I might imagine cheribsd wants to use this one day and there sizeof(void *) == 16 bytes .

bz added a subscriber: bz.Jul 28 2022, 10:02 PM

Apart from the #inlcude I am fine with this.

sys/compat/linuxkpi/common/include/linux/string.h
41

#include <linux/bitops.h> /* for BITS_PER_LONG */

manu updated this revision to Diff 108796.Aug 2 2022, 7:37 AM

Include linux/bitops.h

Harbormaster completed remote builds in B46708: Diff 108796.Aug 2 2022, 7:37 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2022, 2:06 PM
Closed by commit rGfa1f02baafd3: linuxkpi: Add some memset functions (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGfa1f02baafd3: linuxkpi: Add some memset functions.
manu added a commit: rGaf4fb0c0fe1c: linuxkpi: Add some memset functions.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
30 lines

Diff 108544

View Options

sys/compat/linuxkpi/common/include/linux/string.h

Loading...