Page MenuHomeFreeBSD

linuxkpi: Add some memset functions
ClosedPublic

Authored by manu on Jul 26 2022, 9:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 12 2024, 6:53 AM
Unknown Object (File)
Dec 20 2023, 7:16 AM
Unknown Object (File)
Dec 3 2023, 9:51 PM
Unknown Object (File)
Dec 2 2023, 3:00 PM
Unknown Object (File)
Oct 28 2023, 1:59 AM
Unknown Object (File)
Sep 4 2023, 10:46 AM
Unknown Object (File)
Aug 13 2023, 6:03 AM
Unknown Object (File)
Jul 12 2023, 1:07 AM

Details

Summary

Needed by drm-kmod
Obtained from: OpenBSD
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Jul 26 2022, 9:32 AM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/string.h
224

Please make a new loop here:

void **dst = p;

while (n--)
*dst++ = v;

return (p);

Switch memset32/memset64 (badly copy/pasted)

sys/compat/linuxkpi/common/include/linux/string.h
224

Why ?

sys/compat/linuxkpi/common/include/linux/string.h
224

I might imagine cheribsd wants to use this one day and there sizeof(void *) == 16 bytes .

Apart from the #inlcude I am fine with this.

sys/compat/linuxkpi/common/include/linux/string.h
42

#include <linux/bitops.h> /* for BITS_PER_LONG */

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2022, 2:06 PM
This revision was automatically updated to reflect the committed changes.