Page MenuHomeFreeBSD

zfs: Increase compatibility for different environments
ClosedPublic

Authored by imp on Jul 24 2022, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:52 AM
Unknown Object (File)
Fri, Apr 26, 6:52 AM
Unknown Object (File)
Fri, Apr 26, 12:12 AM
Unknown Object (File)
Fri, Apr 26, 12:11 AM
Unknown Object (File)
Thu, Apr 25, 11:28 PM
Unknown Object (File)
Wed, Apr 17, 7:23 AM
Unknown Object (File)
Mar 17 2024, 3:24 AM
Unknown Object (File)
Mar 17 2024, 3:24 AM
Subscribers

Details

Summary

libsa uses the full OpenZFS compilation environment when we build this
included in zfs.c there. Other parts of the tree have not been adapted
to the full OpenZFS environment yet and need these ASSERT* defines to
build properly. Since the ASSERT* macros are normally defined in
sys/debug.h in the OpenZFS compatibility spl, only define them when the
guard for it (_SPL_DEBUG_H) is not defined. This should cover the
non-libsa boot loaders (gptzfsboot in particular) that need to use
zfssubr.c.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 24 2022, 5:45 PM

I am wondering, if we should use #ifndef ASSERT etc instead.

This revision is now accepted and ready to land.Jul 24 2022, 7:37 PM

Move to using #ifndef ASSERT3S
Commit message updated locally.

This revision now requires review to proceed.Jul 24 2022, 8:06 PM
This revision is now accepted and ready to land.Jul 24 2022, 8:15 PM