Page MenuHomeFreeBSD

LinuxKPI: extend kfifo to be usable by a driver
ClosedPublic

Authored by bz on Jul 16 2022, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 4, 1:05 AM
Unknown Object (File)
Dec 15 2022, 7:37 AM

Details

Summary

Implement some basic needs for an actual driver using kfifo.

MFC after: 2 weeks

Test Plan

I had this in user space initially and tested it and it seemed to
work as expected.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jul 16 2022, 12:40 AM
sys/compat/linuxkpi/common/include/linux/kfifo.h
91

Is there a chance of counters wrapping around?

Where is first decremented?

sys/compat/linuxkpi/common/include/linux/kfifo.h
91

First is decremented right below there if it rolls over. It's a FIFO--first and last just move forward (or wrap around).

Now I see. Looks good to me.

This revision is now accepted and ready to land.Jul 17 2022, 6:15 PM

I've done a build against drm-kmod master but I'll wait to hear back from @manu or @wulf on whether it's okay for them too.

It builds for me on master, 5.10-lts and 5.4-lts branches

This revision was automatically updated to reflect the committed changes.