Paths

Table of Contentst

Differential D35715

netinet6: perform out-of-bounds check for lo0 multicast statitics
ClosedPublic
Actions

Authored by melifaro on Jul 4 2022, 8:03 PM.

Tags

None

Referenced Files

	F155051664: D35715.id.diff
	Fri, May 1, 12:06 AM

	F155044366: D35715.diff
	Thu, Apr 30, 10:24 PM

	F155043812: D35715.diff
	Thu, Apr 30, 10:17 PM

	Unknown Object (File)
	Mon, Apr 27, 2:21 PM

	Unknown Object (File)
	Sun, Apr 26, 7:30 PM

	Unknown Object (File)
	Fri, Apr 24, 4:44 PM

	Unknown Object (File)
	Thu, Apr 23, 4:59 AM

	Unknown Object (File)
	Wed, Apr 22, 9:36 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGfc850f4f7d44: netinet6: perform out-of-bounds check for loX multicast statistics
rG0ed72537857b: netinet6: perform out-of-bounds check for loX multicast statistics

Summary

Currently, some per-mbuf multicast statistic is stored in per-interface ip6stat.ip6s_m2m[] array of size 32 (IP6S_M2MMAX).
Check that loopback ifindex falls within 0.. IP6S_M2MMAX-1 range to avoid silent data corruption.
the latter cat happen with large number of VNETs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Jul 4 2022, 8:03 PM

Herald added subscribers: glebius, bz, ae, imp. · View Herald TranscriptJul 4 2022, 8:03 PM

melifaro requested review of this revision.Jul 4 2022, 8:03 PM

Harbormaster completed remote builds in B46263: Diff 107767.Jul 4 2022, 8:03 PM

melifaro edited the summary of this revision. (Show Details)Jul 4 2022, 8:11 PM

melifaro added a reviewer: network.

glebius accepted this revision.Jul 4 2022, 8:12 PM

This revision is now accepted and ready to land.Jul 4 2022, 8:12 PM

Closed by commit rG0ed72537857b: netinet6: perform out-of-bounds check for loX multicast statistics (authored by melifaro). · Explain WhyJul 5 2022, 11:45 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG0ed72537857b: netinet6: perform out-of-bounds check for loX multicast statistics.

melifaro added a commit: rGfc850f4f7d44: netinet6: perform out-of-bounds check for loX multicast statistics.Jan 13 2023, 9:31 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

11 lines

Diff 107780

sys/netinet6/ip6_input.c

Loading...