Differential D35714

tcp: remove a condition in tcp_usr_detach() that never happens
ClosedPublic
Actions

Authored by glebius on Jul 4 2022, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 10:28 AM

	Unknown Object (File)
	Tue, May 19, 8:52 PM

	Unknown Object (File)
	Tue, May 19, 9:35 AM

	Unknown Object (File)
	Sat, May 16, 4:37 AM

	Unknown Object (File)
	Tue, May 12, 3:13 AM

	Unknown Object (File)
	Apr 29 2026, 10:44 PM

	Unknown Object (File)
	Apr 28 2026, 8:40 PM

	Unknown Object (File)
	Apr 27 2026, 1:16 PM

Subscribers

Details

Reviewers

rrs
tuexen

Group Reviewers

Commits

rG1b91978f6375: tcp: remove a condition in tcp_usr_detach() that never happens

Summary

The comment from Robert Watson doubts that this condition ever happens.
Our analysis confirm that. Also, we found that if you manage to create
such a connection with help of some other bug, then after the "second
case" code is execute, the kernel will panic in other parts of the stack.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jul 4 2022, 7:51 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJul 4 2022, 7:51 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jul 4 2022, 7:51 PM

Harbormaster completed remote builds in B46262: Diff 107766.Jul 4 2022, 7:51 PM

tuexen accepted this revision.Jul 4 2022, 8:47 PM

This revision is now accepted and ready to land.Jul 4 2022, 8:47 PM

Closed by commit rG1b91978f6375: tcp: remove a condition in tcp_usr_detach() that never happens (authored by glebius). · Explain WhyJul 7 2022, 4:11 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG1b91978f6375: tcp: remove a condition in tcp_usr_detach() that never happens.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

24 lines

Diff 107870

sys/netinet/tcp_usrreq.c

Loading...