Page MenuHomeFreeBSD
Differential D35512

LinuxKPI: add asm/neon.h
ClosedPublic
Actions

Authored by val_packett.cool on Jun 17 2022, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 4:15 AM
Unknown Object (File)
Thu, Nov 21, 3:25 PM
Unknown Object (File)
Mon, Nov 18, 6:54 PM
Unknown Object (File)
Mon, Nov 18, 6:56 AM
Unknown Object (File)
Mon, Nov 18, 5:35 AM
Unknown Object (File)
Mon, Nov 18, 12:35 AM
Unknown Object (File)
Sun, Nov 17, 8:54 PM
Unknown Object (File)
Sun, Nov 17, 6:31 PM
View All 72 Files
Subscribers
bz
emaste
imp
Contributor Reviews (src)
linuxkpi

Details

Reviewers
manu
• hselasky
imp
bz
Group Reviewers
linuxkpi
Commits
rG8870cb573f4a: LinuxKPI: add asm/neon.h
Summary

This is equivalent to asm/fpu/api.h, but is included by drm on aarch64.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 17 2022, 4:30 PM
Herald added subscribers: linuxkpi, Contributor Reviews (src), emaste, imp. · View Herald TranscriptJun 17 2022, 4:30 PM
val_packett.cool requested review of this revision.Jun 17 2022, 4:30 PM
Harbormaster completed remote builds in B46019: Diff 107006.Jun 17 2022, 4:30 PM
val_packett.cool updated this revision to Diff 107007.Jun 17 2022, 4:31 PM

remove submodule patch

Harbormaster completed remote builds in B46020: Diff 107007.Jun 17 2022, 4:32 PM
val_packett.cool added reviewers: linuxkpi, manu, • hselasky.Jun 17 2022, 4:33 PM
manu added inline comments.Jun 17 2022, 4:41 PM
sys/compat/linuxkpi/common/include/asm/neon.h
38

We try to not follow linux with extern in linuxkpi (at least recently).

val_packett.cool added inline comments.Jun 17 2022, 6:36 PM
sys/compat/linuxkpi/common/include/asm/neon.h
38

hm. the function exists, should I just not declare it as extern? why?

Should the x86 header also be changed in the same patch?

• hselasky added inline comments.Jun 17 2022, 8:11 PM
sys/compat/linuxkpi/common/include/asm/neon.h
38

When declaring prototypes for global functions, the extern keyword is optional. Only for variables it is needed.

I'm good with either version.

imp accepted this revision.Jun 17 2022, 9:08 PM

I'm agnostic about extern, and will leave that detail to others

This revision is now accepted and ready to land.Jun 17 2022, 9:08 PM
• hselasky accepted this revision.Jun 17 2022, 9:18 PM
bz accepted this revision.Jun 17 2022, 9:26 PM
bz added a subscriber: bz.

With the nit please fixed in the last line.

Also raises a question on how we are going to deal with per-arch asm headers eventually in the future ...?

sys/compat/linuxkpi/common/include/asm/neon.h
41

NEON not FPU_API

Closed by commit rG8870cb573f4a: LinuxKPI: add asm/neon.h (authored by val_packett.cool, committed by manu). · Explain WhyJun 21 2022, 5:12 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG8870cb573f4a: LinuxKPI: add asm/neon.h.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
asm/
40 lines

Diff 107213

View Options

sys/compat/linuxkpi/common/include/asm/neon.h

Loading...