Differential D35431

Exclude KASSERTS when rescue retransmissions are in play.
ClosedPublic
Actions

Authored by rscheff on Jun 8 2022, 12:05 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG57317c8971df: tcp: exclude KASSERTS when rescue retransmissions are in play.

Summary

SACK rescue retransmission will inject a new scoreboard
hole beyond snd_fack, if a cummulative ACK with no further
SACK option is received before a SACK loss recovery has
completed (passed snd_recover).

The KASSERT criteria needs to be checked against the
sendbuffer so_snd in a subsequent version.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Jun 8 2022, 12:05 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 8 2022, 12:05 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jun 8 2022, 12:05 PM

Harbormaster completed remote builds in B45907: Diff 106760.Jun 8 2022, 12:05 PM

tuexen accepted this revision.Jun 8 2022, 12:06 PM

This revision is now accepted and ready to land.Jun 8 2022, 12:06 PM

Closed by commit rG57317c8971df: tcp: exclude KASSERTS when rescue retransmissions are in play. (authored by rscheff). · Explain WhyJun 8 2022, 12:54 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG57317c8971df: tcp: exclude KASSERTS when rescue retransmissions are in play..

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_sack.c

22 lines

Diff 106761

View Options

Exclude KASSERTS when rescue retransmissions are in play.ClosedPublicActions