Page MenuHomeFreeBSD

net-mgmt/aircrack-ng: Update to 1.7
Needs ReviewPublic

Authored by salvadore on Jun 6 2022, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 10:48 AM
Unknown Object (File)
Thu, Feb 6, 7:36 PM
Unknown Object (File)
Sat, Jan 18, 12:56 AM
Unknown Object (File)
Nov 29 2024, 1:06 AM
Unknown Object (File)
Nov 23 2024, 3:08 PM
Unknown Object (File)
Nov 20 2024, 12:43 PM
Unknown Object (File)
Nov 13 2024, 5:37 AM
Unknown Object (File)
Nov 13 2024, 5:37 AM

Details

Summary

Moreover, remove USE_GCC=yes, so that this port does not block the
update of GCC default version to GCC 11 anymore. [1]

PR: 264364 [1]
Reported by: exp-run (antoine) [1]

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45874
Build 42762: arc lint + arc unit

Event Timeline

gerald requested changes to this revision.Jun 6 2022, 9:18 PM
gerald added inline comments.
net-mgmt/aircrack-ng/pkg-plist
3–4

So, this is now built even when the SQLITE option (which is ON by default) is OFF? Similar for at least one other instance.

63–68

Hmm, are these really available on non-x86 platforms?

I see

.if ${ARCH:Mpowerpc*}
PLIST_SUB+=     PPC="" \
                X86="@comment "
.elif ${ARCH} == amd64 || ${ARCH} == i386
PLIST_SUB+=     PPC="@comment " \
                X86=""
.endif

in the Makefile, and pkg-plist uses %%X86%% and %%PPC%% in the current version of pkg-plist.

78–79

Not dependent on %%SQLITE%% any longer?

This revision now requires changes to proceed.Jun 6 2022, 9:18 PM
net-mgmt/aircrack-ng/pkg-plist
3–4

I am going to check, thanks.

63–68

Good point. Do you have any resource I can read to help me test the build on powerpc? I tried creating a poudriere jail for powerpc, but I got the error message

Error: You need to install the qemu-user-static package or setup an emulator with binmiscctl(8) for powerpc

And I got the same error message after having installed qemu-user-static.

I confirm that %%SQLITE%% is still needed and I have put it back.

I have also tried to guess how the %%X86%% and %%PPC%% machinery should work. I have tested it successfully on amd64 and i386, but it still needs testing on powerpc.

I confirm that %%SQLITE%% is still needed and I have put it back.

Ah, good.

I have also tried to guess how the %%X86%% and %%PPC%% machinery should work. I have tested it successfully on amd64 and i386, but it still needs testing on powerpc.

For powerpc-specific issues, Piotr Kubaj <pkubaj@FreeBSD.org> has been very active on the ports side and may be able to help, and/or powerpc@FreeBSD.org.

@pkubaj, PowerPC: Could you please help testing this patch on powerpc? Do you have some documentation I can study so that I can learn how to do those tests?

ARM, arm64: I think that my patch might unbreak the port on aarch64, armv6 and armv7. It would be nice to test it on those architectures too, so I ask you too if you can help and suggest me some documentation.

Thanks.

I will test it on my own hardware.
If you want to do it on your own, there are two options:

  • you can test a full VM with qemu-system (will be slow),
  • or you can use native POWER hardware (bare-metal, VM, could be remote since there are providers that offer free POWER VM for open source developers).

AFAIK qemu-user doesn't support POWER, but qemu-system does.

Thank you very much @pkubaj, however @danfe (the port maintainer) asked me in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264364 to pause this review: we committed a patch to let the GCC default version update proceed, but he will deal with the port update later. So, I guess it might be wise to wait until he deals with the update before doing more testing.

Thank you very much also for the suggestions about how to test powerpc.