Expose an interface to determine if an ACE is inherited.

[delphij]

Summary

This is submitted on behalf of sef@. Currently, there is no way to
determine if an ACE was inherited, which prevents properly copying of a hierarchy.

[trasz]

Does the acltools tests still pass with this patch applied?

How does Solaris display that bit? Is it "I", "inherited", just like here?

Please update setfacl.8, acl_add_flag_np.3, and acl.9.

[kithrup_mac.com]

Does the acltools tests still pass with this patch applied?

Where are they?

How does Solaris display that bit? Is it "I", "inherited", just like here?

google's hunt for a Solaris getfacl man page seems to indicate it doesn't have anything about inheritance (looks like the posix1e acl, rather than nfsv4).

Please update setfacl.8, acl_add_flag_np.3, and acl.9.

Will do so.

[trasz]

The tests are at tools/regression/acltools/ in the source tree. I'd expect they will need to be fixed a little, as they depend on textual output from getfacl, and this patch changes it - it expands the 'flags' field by one '-'.

As for Solaris - I've checked it, and it's exactly what they do, so it's fine. (They don't use getfacl, it's "ls -V" there.)

[delphij]

Refresh patchset from sef@

[delphij]

Oops, wrong diff.

[delphij]

Fix a minor space/tab nit.

[bjk]

manpages seem reasonable.
Semicolons are in general somewhat unfriendly to the reader of technical documentation, so the one occurrence in the added text could be converted to a full sentence break, but it is not a blocker.

[wblock]

bin/setfacl/setfacl.1

29 ↗

(On Diff #8434)

Please remember to update this.

385 ↗

(On Diff #8434)

The exception about "inherited" is confusing. Maybe leave the existing section nearly as-is, changing the last sentence to say

These inheritance flags can only be set on directories.

Then add another section after it:

.Bl -tag -width ".Dv short"
.It Short
Long
.It I
​inherited
.El
.Pp
The inherited flag (describe how it is different from the others).

[kithrup_mac.com]

I've got updated diffs, but the interface for this thing still confuses me, so I'm not sure how to get them. (The changes include man page changes, and the regression tests.)

[delphij]

Refresh patch from sef@.

[trasz]

I'm no expert in man pages, but the rest looks good. Thank you!

[delphij]

Space cleanup and diff reduction. (remove ^M's).