Page MenuHomeFreeBSD

kevent: Fix an off-by-one in filt_timerexpire_l()
ClosedPublic

Authored by markj on May 24 2022, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 8, 11:27 AM
Unknown Object (File)
Thu, May 28, 10:32 PM
Unknown Object (File)
Thu, May 28, 6:02 PM
Unknown Object (File)
Wed, May 20, 10:58 PM
Unknown Object (File)
Wed, May 20, 6:09 PM
Unknown Object (File)
Wed, May 20, 7:32 AM
Unknown Object (File)
Sat, May 16, 7:53 PM
Unknown Object (File)
May 1 2026, 3:40 PM
Subscribers

Details

Summary

Suppose a periodic kevent timer fires close to its deadline, so now -
kc->next is small. Then delta ends up being 1, and the next timer
deadline is set to (delta + 1) * kc->to, where kc->to is the timer
period. This means that the timer fires at half of the requested rate.
And, because the computation of delta rounds down, it seems that the
kn_data value is incorrect as well.

PR: 264131
Fixes: 7cb40543e964 ("filt_timerexpire: do not iterate over the interval")

Test Plan

I have some updates to the libkqueue regression test which detect this bug.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable