Page MenuHomeFreeBSD
Differential D35153

kdump: Decode sigset_t.
ClosedPublic
Actions

Authored by dchagin on May 9 2022, 6:58 PM.
Tags
None
Referenced Files
F166320839: D35153.id106483.diff
Wed, Aug 12, 9:41 PM
F166284632: D35153.id106625.diff
Wed, Aug 12, 4:48 PM
Unknown Object (File)
Tue, Aug 11, 6:57 PM
Unknown Object (File)
Mon, Aug 10, 7:02 AM
Unknown Object (File)
Mon, Aug 10, 6:45 AM
Unknown Object (File)
Mon, Aug 10, 6:16 AM
Unknown Object (File)
Mon, Aug 10, 4:49 AM
Unknown Object (File)
Sat, Aug 8, 4:54 PM
View All Files
Subscribers
imp

Details

Reviewers
jhb
markj
emaste
Commits
rG2068608ebdbf: kdump: Decode Linux l_sigset_t.
rG3606a213bfa4: kdump: Decode Linux l_sigset_t.
Summary

I'll add consumers later.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.May 9 2022, 6:58 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 9 2022, 6:58 PM
dchagin requested review of this revision.May 9 2022, 6:58 PM
Harbormaster completed remote builds in B45503: Diff 105791.May 9 2022, 6:58 PM
dchagin edited the summary of this revision. (Show Details)May 9 2022, 7:12 PM
dchagin added a reviewer: jhb.
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin updated this revision to Diff 106483.May 30 2022, 5:18 PM
dchagin edited the summary of this revision. (Show Details)

move to linux.c

Harbormaster completed remote builds in B45774: Diff 106483.May 30 2022, 5:18 PM
dchagin added reviewers: email_luiz.eng.br, markj.May 30 2022, 5:50 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin added parent revisions: D35356: kdump: For future use extract common code to a separate files, D35216: kdump: Decode small amount of Linux syscalls.
dchagin edited reviewers, added: emaste; removed: email_luiz.eng.br.May 30 2022, 5:52 PM
markj added inline comments.May 31 2022, 2:56 PM
usr.bin/kdump/linux.c
194
220
221
224
227

What's the point of making a copy of mask? ktrsigset() doesn't modify it as far as I can see...

dchagin updated this revision to Diff 106617.Jun 3 2022, 8:14 PM

yeah, copy-pasto fixed, thank you!

Harbormaster completed remote builds in B45838: Diff 106617.Jun 3 2022, 8:14 PM
markj added inline comments.Jun 3 2022, 8:47 PM
usr.bin/kdump/linux.c
194

name and mask should be declared const.

215

name and data should be declared const.

dchagin updated this revision to Diff 106625.Jun 3 2022, 10:27 PM

fixed, thanks, Mark

Harbormaster completed remote builds in B45846: Diff 106625.Jun 3 2022, 10:27 PM
markj accepted this revision.Jun 3 2022, 10:28 PM
This revision is now accepted and ready to land.Jun 3 2022, 10:28 PM
Closed by commit rG3606a213bfa4: kdump: Decode Linux l_sigset_t. (authored by dchagin). · Explain WhyJun 22 2022, 11:42 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG3606a213bfa4: kdump: Decode Linux l_sigset_t..
dchagin added a commit: rG2068608ebdbf: kdump: Decode Linux l_sigset_t..Jul 6 2022, 11:06 AM

Revision Contents
Changeset List

PathSize
usr.bin/
kdump/
1 line
5 lines
44 lines

Diff 107234

View Options

usr.bin/kdump/kdump.h

Loading...
View Options

usr.bin/kdump/kdump.c

Loading...
View Options

usr.bin/kdump/linux.c

Loading...