Differential D3508

Code cleanup in fstyp zfs support
ClosedPublic
Actions

Authored by delphij on Aug 27 2015, 7:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 21, 1:38 AM

	Unknown Object (File)
	Fri, Nov 21, 1:32 AM

	Unknown Object (File)
	Fri, Nov 21, 1:32 AM

	Unknown Object (File)
	Fri, Nov 21, 1:27 AM

	Unknown Object (File)
	Thu, Nov 13, 1:28 PM

	Unknown Object (File)
	Oct 28 2025, 7:49 AM

	Unknown Object (File)
	Sep 23 2025, 10:06 AM

	Unknown Object (File)
	Sep 18 2025, 5:12 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS287937: Eliminate unneeded copying of vdev data, goto, etc. and add a note

Summary

Eliminate unneeded copying of vdev data, goto, etc. and add a note
that checksum of vdev label should be checked (which is not done
currently).

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 264
Build 264: arc lint + arc unit

Event Timeline

delphij updated this revision to Diff 8267.Aug 27 2015, 7:58 PM

delphij retitled this revision from to Code cleanup in fstyp zfs support.

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: allanjude.

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2015, 7:58 PM

delphij added a reviewer: ZFS.Sep 1 2015, 6:35 AM

allanjude accepted this revision.Sep 1 2015, 12:47 PM

allanjude edited edge metadata.

This revision is now accepted and ready to land.Sep 1 2015, 12:47 PM

trasz@ would like to see the WARNS level in the Makefile for fstype turned back up. Previously, warnings-as-errors on GCC builds of ZFS made this an issue.

Closed by commit rS287937: Eliminate unneeded copying of vdev data, goto, etc. and add a note (authored by delphij). · Explain WhySep 17 2015, 8:55 PM

This revision was automatically updated to reflect the committed changes.

In D3508#72746, @allanjude wrote:

trasz@ would like to see the WARNS level in the Makefile for fstype turned back up. Previously, warnings-as-errors on GCC builds of ZFS made this an issue.

I have raised it to 2. clang seems to be happy with WARNS?=6 but GCC48 is still complaining and I think we would need to address that in a different revision.

Revision Contents
Changeset List

Path

Size

usr.sbin/

fstyp/

41 lines

Diff 8267

usr.sbin/fstyp/zfs.c

Loading...