Differential D3508

Code cleanup in fstyp zfs support
ClosedPublic
Actions

Authored by delphij on Aug 27 2015, 7:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 4:07 AM

	Unknown Object (File)
	Oct 8 2024, 1:26 AM

	Unknown Object (File)
	Oct 5 2024, 2:00 AM

	Unknown Object (File)
	Oct 4 2024, 10:59 PM

	Unknown Object (File)
	Oct 2 2024, 8:27 AM

	Unknown Object (File)
	Sep 29 2024, 12:30 PM

	Unknown Object (File)
	Sep 28 2024, 7:29 PM

	Unknown Object (File)
	Sep 27 2024, 7:22 AM

View All 77 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS287937: Eliminate unneeded copying of vdev data, goto, etc. and add a note

Summary

Eliminate unneeded copying of vdev data, goto, etc. and add a note
that checksum of vdev label should be checked (which is not done
currently).

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij updated this revision to Diff 8267.Aug 27 2015, 7:58 PM

delphij retitled this revision from to Code cleanup in fstyp zfs support.

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: allanjude.

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2015, 7:58 PM

delphij added a reviewer: ZFS.Sep 1 2015, 6:35 AM

allanjude accepted this revision.Sep 1 2015, 12:47 PM

allanjude edited edge metadata.

This revision is now accepted and ready to land.Sep 1 2015, 12:47 PM

trasz@ would like to see the WARNS level in the Makefile for fstype turned back up. Previously, warnings-as-errors on GCC builds of ZFS made this an issue.

Closed by commit rS287937: Eliminate unneeded copying of vdev data, goto, etc. and add a note (authored by delphij). · Explain WhySep 17 2015, 8:55 PM

This revision was automatically updated to reflect the committed changes.

In D3508#72746, @allanjude wrote:

trasz@ would like to see the WARNS level in the Makefile for fstype turned back up. Previously, warnings-as-errors on GCC builds of ZFS made this an issue.

I have raised it to 2. clang seems to be happy with WARNS?=6 but GCC48 is still complaining and I think we would need to address that in a different revision.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

fstyp/

2 lines

41 lines

Diff 8826

head/usr.sbin/fstyp/Makefile

Loading...

head/usr.sbin/fstyp/zfs.c

Loading...