i386: Fix the nodevice apic build
ClosedPublic
Actions

Authored by markj on Apr 7 2022, 7:13 PM.

Details

Reviewers

kib
jhb
emaste

Commits

rGaa597d4049ff: i386: Fix the nodevice apic build

Summary

PR: 263124
Fixes: 62d09b46ad75 ("x86: Defer LAPIC calibration until after timecounters are available")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 7 2022, 7:13 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2022, 7:13 PM

markj requested review of this revision.Apr 7 2022, 7:13 PM

Harbormaster completed remote builds in B45063: Diff 104741.Apr 7 2022, 7:13 PM

jhb accepted this revision.Apr 7 2022, 11:46 PM

This revision is now accepted and ready to land.Apr 7 2022, 11:46 PM

I wonder if we should just make 'device apic' non-optional on i386 at this point. Any non-ancient machine that can actually run FreeBSD/i386 at this point should have an APIC and you are better off using an I/O APIC to avoid interrupt sharing.

In D34830#789462, @jhb wrote:

I wonder if we should just make 'device apic' non-optional on i386 at this point. Any non-ancient machine that can actually run FreeBSD/i386 at this point should have an APIC and you are better off using an I/O APIC to avoid interrupt sharing.

Weren't there Pentiums (aka 586) and Pentium II/III (686) which had no IOAPIC on m/b? I am not sure completely, but I suspect that LAPIC cannot work in this physical configuration.