Page MenuHomeFreeBSD

mlx4: Comment out a variable only used in commented-out code.
ClosedPublic

Authored by jhb on Apr 7 2022, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 14 2025, 1:53 AM
Unknown Object (File)
Aug 31 2025, 12:47 AM
Unknown Object (File)
Aug 31 2025, 12:38 AM
Unknown Object (File)
Aug 23 2025, 11:43 PM
Unknown Object (File)
Jul 28 2025, 2:29 AM
Unknown Object (File)
Jun 14 2025, 8:49 PM
Unknown Object (File)
Jun 10 2025, 9:03 AM
Unknown Object (File)
Jun 1 2025, 8:35 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45058
Build 41946: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 7 2022, 6:01 PM

Just delete those lines. No need to comment out.

This revision is now accepted and ready to land.Apr 8 2022, 9:35 AM
sys/dev/mlx4/mlx4_core/mlx4_eq.c
615

Hmm, if I remove this bit of commented out code then this is just 'if (0)'. Removing that bit of dead code exposes quite a bit more dead code (everything between lines 610 and 620 as well as lines 646 through 663. I can post an updated review to do that if you'd prefer.

I was just thinking about removing this line:

/* s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; */

I was just thinking about removing this line:

/* s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; */

Ok. That does orphan the next line below each one, but I can do just delete the lines you suggest.