Page MenuHomeFreeBSD

mlx4: Comment out a variable only used in commented-out code.
ClosedPublic

Authored by jhb on Apr 7 2022, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:25 PM
Unknown Object (File)
Mon, Jan 13, 9:35 PM
Unknown Object (File)
Dec 4 2024, 11:46 AM
Unknown Object (File)
Nov 20 2024, 4:52 PM
Unknown Object (File)
Oct 25 2024, 8:26 AM
Unknown Object (File)
Oct 13 2024, 12:01 AM
Unknown Object (File)
Oct 12 2024, 9:58 PM
Unknown Object (File)
Oct 9 2024, 3:35 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 7 2022, 6:01 PM

Just delete those lines. No need to comment out.

This revision is now accepted and ready to land.Apr 8 2022, 9:35 AM
sys/dev/mlx4/mlx4_core/mlx4_eq.c
613

Hmm, if I remove this bit of commented out code then this is just 'if (0)'. Removing that bit of dead code exposes quite a bit more dead code (everything between lines 610 and 620 as well as lines 646 through 663. I can post an updated review to do that if you'd prefer.

I was just thinking about removing this line:

/* s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; */

I was just thinking about removing this line:

/* s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; */

Ok. That does orphan the next line below each one, but I can do just delete the lines you suggest.