Updated Ports: net-im/libsignal, net-im/signal-cli, net-im/signald, net-im/zkgroup

[sec.research.2005_gmail.com]

Summary

Updated all Signal Messenger related ports - libsignal, signal-cli, signald, and zkgroup to their respective latest version.

Some notes

• libsignal and zkgroup are Rust packages, and signal-cli and signald are Java.
• libsignal-client has been renamed upsteream to libsignal, so I renamed the port to match upstream naming.
• signal-cli now needs JDK 17+, and signald still needs JDK 11 (JDK 16+ not supported)
• Both signal-cli and signald now depend on sqlite JDBC driver.
  • The port version of sqlite JDBC driver is very old and cannot be used.
  • For now I have just kept the jar that gets bundled as part of the build and not replaced it with the port version. This jar includes the FreeBSD native library for sqlite. The native library is extracted at runtime to $TMPDIR which defaults to /tmp.
  • However, this is problematic when /tmp is mounted with noexec, in which case the following works.

mkdir -p $HOME/TMP
env _JAVA_OPTIONS=-Djava.io.tmpdir=$HOME/TMP
/usr/local/bin/signal-cli 
#OR
/usr/local/bin/signald

I was wondering if there is a better way to manage this. Or will a simple pkg message will suffice.

Test Plan

I have tested these ports on my local machine (AMD64, FreeBSD 13.0-RELEASE-p10). I would be happy to follow a more rigorous test plan if provided directions. I am fairly new to FreeBSD porting, so would appreciate any direction.

[tcberner]

net-im/signal-cli/Makefile

19

RUN_DEPENDS on net-im/libsignal should not be necessary due to the LIB_DEPENDS

net-im/signald/Makefile

136–137

^ don't comment, remove -- unless there is a reason for it to stick around, but then add a comment on why :)

net-im/zkgroup/Makefile

4

^ PORTREVISION can be removed as DISTVERSION increases

[sec.research.2005_gmail.com]

All comments addressed as per the review.

[0mp]

Hey, thanks a lot for the submission and I'm really sorry, I've not got a notification by email.

I cannot test the patch at the moment, but there seems to be a growing interest in the community: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267407. Perhaps you could coordinate some testing with other folks.

pkg-message would be sufficient. In the future, however, we could create a shell script wrapper for signal-cli, which sets appropriate variables (e.g., tries /tmp first, then /var/tmp, and finally $HOME/.cache/).