Page MenuHomeFreeBSD
Differential D34656

Enable building and installing DTrace test suite by default on amd64
Needs ReviewPublic
Actions

Authored by lwhsu on Mar 24 2022, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 2:39 PM
Unknown Object (File)
Thu, Jan 8, 4:53 AM
Unknown Object (File)
Tue, Jan 6, 1:06 AM
Unknown Object (File)
Dec 30 2025, 5:46 AM
Unknown Object (File)
Dec 24 2025, 11:31 PM
Unknown Object (File)
Dec 24 2025, 4:01 PM
Unknown Object (File)
Dec 22 2025, 11:17 PM
Unknown Object (File)
Dec 15 2025, 1:10 AM
View All 93 Files
Subscribers
bdrewery
imp

Details

Reviewers
markj
emaste
Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44883
Build 41771: arc lint + arc unit

Event Timeline

lwhsu created this revision.Mar 24 2022, 4:23 AM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptMar 24 2022, 4:23 AM
lwhsu requested review of this revision.Mar 24 2022, 4:23 AM
Harbormaster completed remote builds in B44869: Diff 104143.Mar 24 2022, 4:23 AM
markj added a comment.Mar 24 2022, 3:38 PM

Did you try this with KASAN by any chance? I don't think I have.

emaste added a comment.Mar 24 2022, 3:52 PM

I assume the DTrace tests will be included in a default kyua run when this option is set?

tools/build/options/WITHOUT_DTRACE_TESTS
6

IMO avoid mentioning the architecture in here; it's very likely that we'd forget to update it if/when we update it for 2nd architecture, and makeman adds the list of default on/off architectures already. Maybe "is considered experimental on architectures where it is not enabled by default"?

(I see that this is based on the text already in WITH_DTRACE_TESTS.)

lwhsu added a comment.Mar 24 2022, 4:33 PM
In D34656#785225, @markj wrote:

Did you try this with KASAN by any chance? I don't think I have.

I just enabled KASAN for dtrace test: https://github.com/freebsd/freebsd-ci/commit/aec6d5e061890c40938f0dc7937037d1c6ff7347
Let's see how it goes.

lwhsu updated this revision to Diff 104169.Mar 24 2022, 4:51 PM

Tweak description in src.conf

Harbormaster completed remote builds in B44883: Diff 104169.Mar 24 2022, 4:51 PM

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines
tools/
build/
options/
5 lines
4 lines

Diff 104169

View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/options/WITHOUT_DTRACE_TESTS

Loading...
View Options

tools/build/options/WITH_DTRACE_TESTS

Loading...