Page MenuHomeFreeBSD

Enable building and installing DTrace test suite by default on amd64
Needs ReviewPublic

Authored by lwhsu on Mar 24 2022, 4:23 AM.

Details

Reviewers
markj
emaste
Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 44883
Build 41771: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Mar 24 2022, 4:23 AM

Did you try this with KASAN by any chance? I don't think I have.

I assume the DTrace tests will be included in a default kyua run when this option is set?

tools/build/options/WITHOUT_DTRACE_TESTS
5

IMO avoid mentioning the architecture in here; it's very likely that we'd forget to update it if/when we update it for 2nd architecture, and makeman adds the list of default on/off architectures already. Maybe "is considered experimental on architectures where it is not enabled by default"?

(I see that this is based on the text already in WITH_DTRACE_TESTS.)

Did you try this with KASAN by any chance? I don't think I have.

I just enabled KASAN for dtrace test: https://github.com/freebsd/freebsd-ci/commit/aec6d5e061890c40938f0dc7937037d1c6ff7347
Let's see how it goes.

Tweak description in src.conf