Page MenuHomeFreeBSD

bsdinstall/partedit: Replace libdialog with libbsddialog
ClosedPublic

Authored by asiciliano on Mar 22 2022, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 6:45 AM
Unknown Object (File)
Fri, Apr 19, 11:44 AM
Unknown Object (File)
Fri, Apr 19, 11:44 AM
Unknown Object (File)
Fri, Apr 19, 11:44 AM
Unknown Object (File)
Fri, Apr 19, 11:39 AM
Unknown Object (File)
Tue, Apr 16, 5:55 AM
Unknown Object (File)
Mar 17 2024, 11:27 AM
Unknown Object (File)
Jan 28 2024, 7:41 PM
Subscribers

Details

Summary

bsdinstall/partedit and sade(8): Replace (LGPL) libdialog with (BSD-2-Clause) libbsddialog. change only User Iterface everything else is left unchanged (for example an unused variable scripted.c:73:6: warning: variable 'error' set but not used [-Wunused-but-set-variable] int error;). Rewrite diskeditor.c because it uses an API totally incompatible with bsddialog.

Test Plan

The forms are the new components, all others are already in use. Probably sade uses all the dialogs so it is a good test case to continue the replacement process.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

simple remark, not mandatory to follow ;), otherwise LGTM

usr.sbin/bsdinstall/partedit/diskmenu.c
60

using asprintf would simplify this

This revision is now accepted and ready to land.Mar 23 2022, 8:14 AM
This revision now requires review to proceed.Mar 23 2022, 3:39 PM

Apply tip

usr.sbin/bsdinstall/partedit/diskmenu.c
60

updated

This revision is now accepted and ready to land.Mar 23 2022, 3:43 PM

I am not familiar with dialogs or this code. I've tried to look for GEOM-related changes, but haven't found any.