Page MenuHomeFreeBSD

teken: color #3 is yellow not brown - use TC_YELLOW as the name
ClosedPublic

Authored by emaste on Mar 11 2022, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 20 2024, 2:39 PM
Unknown Object (File)
Oct 20 2024, 2:38 PM
Unknown Object (File)
Oct 20 2024, 2:38 PM
Unknown Object (File)
Oct 20 2024, 2:07 PM
Unknown Object (File)
Oct 19 2024, 4:08 PM
Unknown Object (File)
Oct 3 2024, 8:31 PM
Unknown Object (File)
Sep 26 2024, 2:54 PM
Unknown Object (File)
Sep 26 2024, 8:55 AM
Subscribers

Details

Summary

The console escape code standard (ECMA-48) specifies color #3 (escape code 33) as yellow.

A brown console color is an artifact of the VGA palette, which replaces dim (but not bright) yellow with brown.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 11 2022, 9:45 PM
sys/sys/terminal.h
97

hmm, these may appear in kernel config files. This should probably be

#define FG_YELLOW TCOLOR_FG(TC_YELLOW)
#define FG_BROWN FG_YELLOW

and below

#define FG_LIGHTYELLOW (TFORMAT(TF_BOLD) | TCOLOR_FG(TC_YELLOW))

and similar for BG_*

sys/sys/terminal.h
97

Probably best to leave them alone since they most likely are/were being used with VGA consoles, and already have some inconsistencies with console escape names (e.g. white)