Page MenuHomeFreeBSD

bsdinstall/distfetch: replace libdialog with libbsddialog
ClosedPublic

Authored by asiciliano on Mar 7 2022, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 3:31 PM
Unknown Object (File)
Jan 28 2024, 7:22 PM
Unknown Object (File)
Jan 28 2024, 7:22 PM
Unknown Object (File)
Jan 28 2024, 7:22 PM
Unknown Object (File)
Jan 28 2024, 5:27 PM
Unknown Object (File)
Jan 14 2024, 4:15 PM
Unknown Object (File)
Jan 1 2024, 4:47 AM
Unknown Object (File)
Dec 29 2023, 7:00 PM
Subscribers

Details

Summary

Replace LGPL libdialog with permissive libbsddialog.
Moreover diversify the error messages, unfortunately the numbers of errors during the fetching is growing (mainly in VM, example https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261653), so we can find quickly the exact point of failure.

Test Plan

% cd usr.sbin/bsdinstall/distfetch/
% make
% mkdir download
% env DISTRIBUTIONS="kernel.txz lib32.txz tests.txz" BSDINSTALL_DISTDIR="./download" BSDINSTALL_DISTSITE="https://download.freebsd.org/ftp/snapshots/amd64/14.0-CURRENT/" ./distfetch

                                                             
┌────────┤Fetching Distribution├───────┐                     
│ kernel.txz           [    Done     ] │                     
│ lib32.txz            [    Done     ] │                     
│ tests.txz            [    Done     ] │                     
│                                      │                     
│ Fetching distribution completed      │                     
│                                      │                     
│  ┌─Overall Progress───────────────┐  │                     
│  │              100%              │  │                     
│  └────────────────────────────────┘  │                     
└──────────────────────────────────────┘

% ls download/
kernel.txz lib32.txz tests.txz
% make clean ; make cleandir
% rm -R download/

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/bsdinstall/distfetch/Makefile
5–6

This is because we're not (yet/currently) installing bsddialog's headers?

usr.sbin/bsdinstall/distfetch/Makefile
5–6

Thank you for the comment,

Probably because the library is private,
I follow @bapt' s template (https://cgit.freebsd.org/src/tree/usr.sbin/tzsetup/Makefile) for Makefiles,
of course I can change if you prefer other solutions.

Probably because the library is private,

Ah right, this is necessary for private libraries.

This revision is now accepted and ready to land.Mar 15 2022, 4:31 PM