Page MenuHomeFreeBSD
Differential D34272

riscv: Add various pmap definitions needed to support SV48 mode
ClosedPublic
Actions

Authored by markj on Feb 14 2022, 10:29 PM.

Details

Reviewers
jhb
Commits
rG59f192c507c4: riscv: Add various pmap definitions needed to support SV48 mode
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Feb 14 2022, 10:29 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 14 2022, 10:29 PM
markj requested review of this revision.Feb 14 2022, 10:29 PM
Harbormaster completed remote builds in B44441: Diff 102758.Feb 14 2022, 10:29 PM
markj added a parent revision: D34271: riscv: Use generic CSR macros for writing SATP.Feb 14 2022, 10:29 PM
markj added a child revision: D34273: riscv: Define the SV48 memory map.
jhb accepted this revision.Feb 14 2022, 11:56 PM
jhb added a subscriber: jhb.
jhb added inline comments.
sys/riscv/include/vmparam.h
183–186

Does it make sense to include the _SV48 constants in this commit?

This revision is now accepted and ready to land.Feb 14 2022, 11:56 PM
markj updated this revision to Diff 102799.Feb 15 2022, 3:19 PM

Add PS_STRINGS_SV39

This revision now requires review to proceed.Feb 15 2022, 3:19 PM
Harbormaster completed remote builds in B44465: Diff 102799.Feb 15 2022, 3:19 PM
jhb accepted this revision.Feb 15 2022, 5:41 PM
This revision is now accepted and ready to land.Feb 15 2022, 5:41 PM
alc added a subscriber: alc.Feb 18 2022, 5:38 AM
alc added inline comments.
sys/vm/pmap.h
97–103 ↗(On Diff #102799)

I don't see why this is defined in the MI-level pmap,h as opposed to riscv/include/pmap.h.

markj updated this revision to Diff 102932.Feb 18 2022, 2:03 PM
markj marked an inline comment as done.

Define pmap_mode in the right header.

This revision now requires review to proceed.Feb 18 2022, 2:03 PM
Harbormaster completed remote builds in B44497: Diff 102932.Feb 18 2022, 2:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2022, 2:40 PM
Closed by commit rG59f192c507c4: riscv: Add various pmap definitions needed to support SV48 mode (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG59f192c507c4: riscv: Add various pmap definitions needed to support SV48 mode.

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
7 lines
10 lines
12 lines
riscv/
18 lines

Diff 103330

View Options

sys/riscv/include/pmap.h

Loading...
View Options

sys/riscv/include/pte.h

Loading...
View Options

sys/riscv/include/vmparam.h

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...