Page MenuHomeFreeBSD

bwi: Fix clang 14 warning about possible unaligned access
ClosedPublic

Authored by dim on Feb 7 2022, 9:01 PM.
Tags
None
Referenced Files
F94109831: D34196.diff
Sun, Sep 15, 4:02 PM
Unknown Object (File)
Thu, Sep 12, 2:49 AM
Unknown Object (File)
Wed, Sep 4, 2:48 PM
Unknown Object (File)
Sat, Aug 31, 5:51 PM
Unknown Object (File)
Aug 11 2024, 8:40 PM
Unknown Object (File)
Aug 10 2024, 10:52 PM
Unknown Object (File)
Aug 9 2024, 1:46 AM
Unknown Object (File)
Aug 9 2024, 1:46 AM
Subscribers
None

Details

Summary

On architectures with strict alignment requirements (e.g. arm), clang 14
warns about a packed struct which encloses a non-packed union:

In file included from sys/dev/bwi/bwimac.c:79:
sys/dev/bwi/if_bwivar.h:308:7: error: field iv_val within 'struct bwi_fw_iv' is less aligned than 'union (unnamed union at sys/dev/bwi/if_bwivar.h:305:2)' and is usually due to 'struct bwi_fw_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
        }                       iv_val;
                                ^

It appears to help if you also add __packed to the inner union (i.e.
iv_val). No change to the layout is intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44326
Build 41214: arc lint + arc unit