Page MenuHomeFreeBSD

bwi: Fix clang 14 warning about possible unaligned access
ClosedPublic

Authored by dim on Feb 7 2022, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 12:24 PM
Unknown Object (File)
Fri, Jan 24, 5:29 PM
Unknown Object (File)
Tue, Jan 21, 3:53 PM
Unknown Object (File)
Mon, Jan 20, 3:48 AM
Unknown Object (File)
Sat, Jan 18, 3:46 AM
Unknown Object (File)
Fri, Jan 17, 3:54 PM
Unknown Object (File)
Thu, Jan 16, 9:54 AM
Unknown Object (File)
Wed, Jan 1, 10:26 AM
Subscribers
None

Details

Summary

On architectures with strict alignment requirements (e.g. arm), clang 14
warns about a packed struct which encloses a non-packed union:

In file included from sys/dev/bwi/bwimac.c:79:
sys/dev/bwi/if_bwivar.h:308:7: error: field iv_val within 'struct bwi_fw_iv' is less aligned than 'union (unnamed union at sys/dev/bwi/if_bwivar.h:305:2)' and is usually due to 'struct bwi_fw_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
        }                       iv_val;
                                ^

It appears to help if you also add __packed to the inner union (i.e.
iv_val). No change to the layout is intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable