Page MenuHomeFreeBSD

unix/dgram: return EAGAIN instead of ENOBUFS when O_NONBLOCK set
ClosedPublic

Authored by glebius on Feb 6 2022, 6:33 PM.
Tags
None
Referenced Files
F132154811: D34187.diff
Tue, Oct 14, 6:36 AM
Unknown Object (File)
Mon, Oct 13, 4:17 AM
Unknown Object (File)
Fri, Oct 10, 6:28 PM
Unknown Object (File)
Fri, Oct 10, 6:28 PM
Unknown Object (File)
Fri, Oct 10, 6:28 PM
Unknown Object (File)
Fri, Oct 10, 1:29 PM
Unknown Object (File)
Fri, Sep 19, 10:43 AM
Unknown Object (File)
Tue, Sep 16, 11:57 PM
Subscribers

Details

Summary

This is behavior what some programs expect and what Linux does. For
example nginx expects EAGAIN when sending messages to /var/run/log,
which it connects to with O_NONBLOCK. Particularly with nginx the
problem is magnified by the fact that a ENOBUFS on send(2) is also
logged, so situation creates a log-bomb - a failed log message
triggers another log message.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is probably ok. EAGAIN is the usual error value for this case. I thought this would break our syslog(3), which explicitly checks for ENOBUFS, but it uses a blocking socket.

This revision is now accepted and ready to land.Feb 6 2022, 10:35 PM