Page MenuHomeFreeBSD
Differential D34086

ktls: Write-lock the INP when changing a transmit TLS session.
ClosedPublic
Actions

Authored by jhb on Jan 28 2022, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 3:10 AM
Unknown Object (File)
Thu, Apr 11, 11:09 PM
Unknown Object (File)
Feb 22 2024, 11:09 AM
Unknown Object (File)
Feb 12 2024, 8:30 AM
Unknown Object (File)
Feb 8 2024, 8:44 PM
Unknown Object (File)
Dec 20 2023, 12:48 AM
Unknown Object (File)
Dec 13 2023, 2:19 AM
Unknown Object (File)
Dec 3 2023, 2:10 AM
View All 30 Files
Subscribers
• hselasky
imp
rrs

Details

Reviewers
gallatin
• hselasky
Commits
rG48e6b7ad3557: ktls: Write-lock the INP when changing a transmit TLS session.
rGcd0525f615fe: ktls: Write-lock the INP when changing a transmit TLS session.
Summary

The TCP rate pacing code relies on being able to read this pointer
safely while holding an INP lock. The initial TLS session pointer is
set while holding the write lock already.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 28 2022, 9:30 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 28 2022, 9:30 PM
jhb requested review of this revision.Jan 28 2022, 9:30 PM
Harbormaster completed remote builds in B44151: Diff 102061.Jan 28 2022, 9:30 PM
jhb added a parent revision: D34085: tcp_ratelimit: Handle some edge cases with TLS + RL send tags..Jan 28 2022, 9:30 PM
gallatin accepted this revision.Jan 28 2022, 9:49 PM
This revision is now accepted and ready to land.Jan 28 2022, 9:49 PM
• hselasky added a comment.Jan 29 2022, 9:50 AM

Is it allowed to lock the INP after SOCKBUF? I thought you needed to lock INP first, then SOCKBUF?

jhb updated this revision to Diff 102185.Feb 1 2022, 12:42 AM
  • Lock INP before socket buffer.
This revision now requires review to proceed.Feb 1 2022, 12:42 AM
Harbormaster completed remote builds in B44205: Diff 102185.Feb 1 2022, 12:43 AM
• hselasky accepted this revision.Feb 1 2022, 9:57 AM
This revision is now accepted and ready to land.Feb 1 2022, 9:57 AM
gallatin accepted this revision.Feb 1 2022, 3:58 PM
Closed by commit rGcd0525f615fe: ktls: Write-lock the INP when changing a transmit TLS session. (authored by jhb). · Explain WhyFeb 11 2022, 11:17 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGcd0525f615fe: ktls: Write-lock the INP when changing a transmit TLS session..
jhb added a commit: rG48e6b7ad3557: ktls: Write-lock the INP when changing a transmit TLS session..May 11 2022, 12:30 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 102686

View Options

sys/kern/uipc_ktls.c

Loading...