cp: fix -R with links
ClosedPublic
Actions

Authored by kevans on Jan 27 2022, 6:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 27 2025, 1:28 AM

	Unknown Object (File)
	Nov 15 2025, 8:03 PM

	Unknown Object (File)
	Nov 15 2025, 8:03 PM

	Unknown Object (File)
	Nov 15 2025, 8:03 PM

	Unknown Object (File)
	Nov 15 2025, 6:12 PM

	Unknown Object (File)
	Nov 14 2025, 5:31 PM

	Unknown Object (File)
	Nov 14 2025, 3:05 PM

	Unknown Object (File)
	Nov 14 2025, 1:48 PM

View All Files

Subscribers

imp

Details

Reviewers

bapt
allanjude
asomers

Commits

rG33ad990ce974: cp: fix -R with links

Summary

The traversal was previously not properly honored -H/-L/-P; notably, we
should not have been resolving symlinks for -H or -P.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 27 2022, 6:06 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2022, 6:06 PM

kevans requested review of this revision.Jan 27 2022, 6:06 PM

Harbormaster completed remote builds in B44124: Diff 102003.Jan 27 2022, 6:06 PM

bapt accepted this revision.Jan 28 2022, 8:20 AM

This revision is now accepted and ready to land.Jan 28 2022, 8:20 AM

Closed by commit rG33ad990ce974: cp: fix -R with links (authored by kevans). · Explain WhyFeb 22 2022, 10:06 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG33ad990ce974: cp: fix -R with links.

Revision Contents
Changeset List

Path

Size

bin/

cp/

cp.c

23 lines

tests/

cp_test.sh

64 lines

Diff 103126

View Options

bin/cp/cp.c