install-boot.sh: Avoid - in function names for POSIX compatibility
ClosedPublic
Actions

Authored by jrtc27 on Jan 22 2022, 1:19 AM.

Details

Reviewers

emaste
brooks

Group Reviewers

releng

Commits

rG17160f21efe8: install-boot.sh: Avoid - in function names for POSIX compatibility

Summary

FreeBSD sh supports this but other common POSIX shells do not; in
particular, dash does not, unlike bash and zsh. This allows the script
to be used on non-FreeBSD systems for release media building.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jan 22 2022, 1:19 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2022, 1:19 AM

jrtc27 requested review of this revision.Jan 22 2022, 1:19 AM

Harbormaster completed remote builds in B44044: Diff 101770.Jan 22 2022, 1:19 AM

jrtc27 added a child revision: D34001: release: Add support for building on non-FreeBSD.Jan 22 2022, 1:20 AM

emaste accepted this revision.Jan 22 2022, 2:45 AM

This revision is now accepted and ready to land.Jan 22 2022, 2:45 AM

brooks accepted this revision.Jan 22 2022, 6:47 PM

Closed by commit rG17160f21efe8: install-boot.sh: Avoid - in function names for POSIX compatibility (authored by jrtc27). · Explain WhyFeb 28 2022, 10:42 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG17160f21efe8: install-boot.sh: Avoid - in function names for POSIX compatibility.

Revision Contents
Changeset List

Path

Size

tools/

boot/

install-boot.sh

18 lines

Diff 103311

View Options

tools/boot/install-boot.sh

install-boot.sh: Avoid - in function names for POSIX compatibilityClosedPublicActions