Differential D3391

Prefer pciids if available as a database for pciconf(8)
ClosedPublic
Actions

Authored by bapt on Aug 15 2015, 8:28 PM.

Tags

None

Referenced Files

	F94172460: D3391.diff
	Mon, Sep 16, 1:57 AM

	F94083689: D3391.diff
	Sun, Sep 15, 11:21 AM

	Unknown Object (File)
	Thu, Sep 12, 8:08 AM

	Unknown Object (File)
	Thu, Sep 12, 2:42 AM

	Unknown Object (File)
	Mon, Aug 19, 4:05 AM

	Unknown Object (File)
	Sun, Aug 18, 8:05 AM

	Unknown Object (File)
	Aug 16 2024, 7:36 PM

	Unknown Object (File)
	Aug 16 2024, 6:01 AM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rS287746: MFC: r287522
rS287522: Prefer pciids database from ports if present

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 7968.Aug 15 2015, 8:28 PM

bapt retitled this revision from to Prefer pciids if available as a database for pciconf(8).

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

Herald added a reviewer: manpages. · View Herald TranscriptAug 15 2015, 8:28 PM

Herald added a subscriber: imp. · View Herald Transcript

bapt added a reviewer: wollman.Aug 15 2015, 9:01 PM

wblock added a subscriber: wblock.Aug 16 2015, 2:59 AM

wblock added inline comments.

usr.sbin/pciconf/pciconf.8
286 ↗	(On Diff #7968)	Let's rearrange this to be clearer: PCI vendor and device information is read from .Pa /usr/local/share/pciids/pci.ids . If that file is not present, it is read from .Pa /usr/share/misc/pci_vendors .
usr.sbin/pciconf/pciconf.c
552 ↗	(On Diff #7968)	Is a change that defines _PATH_LPCIVDB missing?

bapt added inline comments.Aug 17 2015, 3:19 PM

usr.sbin/pciconf/pciconf.c
552 ↗	(On Diff #7968)	It is on the first part of this review (in pathname.h)

wblock added inline comments.Aug 18 2015, 2:49 AM

usr.sbin/pciconf/pciconf.c
552 ↗	(On Diff #7968)	Huh. I could swear that did not appear when I first saw this.

No objection in principle but it's been far too long since I had anything to do with this code to express an opinion on the change itself.

Closed by commit rS287522: Prefer pciids database from ports if present (authored by bapt). · Explain WhySep 6 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

pciconf/

1 line

6 lines

7 lines

Diff 8524

head/usr.sbin/pciconf/pathnames.h

Loading...

head/usr.sbin/pciconf/pciconf.8

Loading...

head/usr.sbin/pciconf/pciconf.c

Loading...