Page MenuHomeFreeBSD

Prefer pciids if available as a database for pciconf(8)
ClosedPublic

Authored by bapt on Aug 15 2015, 8:28 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt updated this revision to Diff 7968.Aug 15 2015, 8:28 PM
bapt retitled this revision from to Prefer pciids if available as a database for pciconf(8).
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
wblock added a subscriber: wblock.Aug 16 2015, 2:59 AM
wblock added inline comments.
usr.sbin/pciconf/pciconf.8
286 ↗(On Diff #7968)

Let's rearrange this to be clearer:

PCI vendor and device information is read from
.Pa /usr/local/share/pciids/pci.ids .
If that file is not present, it is read from
.Pa /usr/share/misc/pci_vendors .
usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

Is a change that defines _PATH_LPCIVDB missing?

bapt added inline comments.Aug 17 2015, 3:19 PM
usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

It is on the first part of this review (in pathname.h)

wblock added inline comments.Aug 18 2015, 2:49 AM
usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

Huh. I could swear that did not appear when I first saw this.

wollman resigned from this revision.Sep 6 2015, 7:55 PM
wollman removed a reviewer: wollman.

No objection in principle but it's been far too long since I had anything to do with this code to express an opinion on the change itself.

This revision was automatically updated to reflect the committed changes.