Page MenuHomeFreeBSD

Prefer pciids if available as a database for pciconf(8)
ClosedPublic

Authored by bapt on Aug 15 2015, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 6:25 AM
Unknown Object (File)
Tue, Mar 12, 6:25 AM
Unknown Object (File)
Tue, Mar 12, 4:14 AM
Unknown Object (File)
Fri, Mar 8, 7:12 AM
Unknown Object (File)
Feb 27 2024, 3:54 PM
Unknown Object (File)
Jan 14 2024, 6:39 PM
Unknown Object (File)
Dec 8 2023, 7:40 PM
Unknown Object (File)
Nov 28 2023, 4:10 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt retitled this revision from to Prefer pciids if available as a database for pciconf(8).
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
wblock added inline comments.
usr.sbin/pciconf/pciconf.8
286 ↗(On Diff #7968)

Let's rearrange this to be clearer:

PCI vendor and device information is read from
.Pa /usr/local/share/pciids/pci.ids .
If that file is not present, it is read from
.Pa /usr/share/misc/pci_vendors .
usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

Is a change that defines _PATH_LPCIVDB missing?

usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

It is on the first part of this review (in pathname.h)

usr.sbin/pciconf/pciconf.c
552 ↗(On Diff #7968)

Huh. I could swear that did not appear when I first saw this.

wollman removed a reviewer: wollman.

No objection in principle but it's been far too long since I had anything to do with this code to express an opinion on the change itself.

This revision was automatically updated to reflect the committed changes.